I don't understand this report; with this series applied, line 867 is the following: 867 UINT8 *Src, *Dst; coming from patch v14 37/46, "OvmfPkg/Sec: Add #VC exception handling for Sec

So line 867 of SecMain.c has: UINT8 *Src, *Dst; which appears correct to me, so I believe that is an issue with the tool? I'll fix this. I'll fix this. I'll fix this. I'll fix this. I'm trying

Hi Bret, Sorry for the delayed response. Some more comments here: 1. Currently I see the LockVaribePolicy is called at ReadyToBoot by variable driver, could we update it to be called at EndOfDxe?

I prefer to directly revert the patch. It simplifies the change history.

Can you please explain this in detail? It's ok to not provide the "root" cause of why the image boot behavior is different. Saying the specific issue can help people to understand the issue in

Hi Zhichao, Some patches in this series need reworking. Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error

Reminder for review of this series Thanks, --Samer

Thanks Pete. Ard, Leif, If there are no concerns, can you please push this patch, along with the other series that are

It is slight complex, I will review it by 9/11/2020. Thanks.

I will review the patch by next week(8/21). Thanks Guomin

Reviewed-by: Guomin Jiang <guomin.jiang@...> Thanks Guomin

+Hao, Ray, Hi Libo, thanks for your explanation. So I think the patch is improvement for current logic. Hi Hao and Ray, Can you give some comments for the change. Hi Jeremy, It

Hello, Mr. Jiang, Thank for the review. The original enumeration steps in the function of UsbEnumerateNewDev of file UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max Packet

Ray, The MBR info is correct. The order change is to avoid the MBR being checked before UDF/ISO 9660 check. That is why I make the patch #3 in the last of the patch set. Thanks, Zhichao

I also add some variables to calculate StartingLBA and SizeInLBA instead of calculate them when they are needed. I am fine to revert the whole changes. Just make you aware of this. Thanks, Zhichao

Hi Guomin, I'd suggest that you add a section to describe clearly the required steps to enable this feature in a platform. I just noticed that SecMigrationPei.inf is not mentioned for doing

How am I supposed to review this change? The commit log is empty and I was not cc'ed on the cover letter. In general, please try to muster up the energy to write at least one sentence that describes

Acked-by: Ard Biesheuvel <ard.biesheuvel@...>

Reviewed-by: Ray Ni <ray.ni@...>

Zhichao, Can you please just revert the fix you recently added?