In python3, array.array.tostring() was a compat alias for tobytes(). tostring() was removed in python 3.9. Convert this to use tolist() which should be valid for all python versions. This fixes this

Hi Qi, Two common comments here. More specific comments will be given separately in each patch email later. c1. SecurityPkg/Library/DxeTpmMeasurementLib/EventLogRecord.c and

No worries, easy enough to do if I'm already updating the others. I would like to be able to run this tool on my system, though, to see if anything else gets flagged after fixing the above mentioned

(1) This patch does not cover "OvmfPkg/Bhyve/BhyvePkgX64.dsc", which also resolves "OpensslLib". (2) Please add the RngLib resolution just after the "OpensslLib" resolution(s), in each of the five

In addition to the documentation updates requested by Ard and myself under the OvmfPkg patch (non-empty commit message body, BZ reference), I'd like to request that we add the RngLib resolution near

Hi Ard! Cover letter: [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib https://edk2.groups.io/g/devel/message/63944

Hello Shenglei, (+Ard) 2/16: ".pytool/Plugin: Add a plugin EccCheck" 2/16: ".pytool/Plugin: Add a plugin EccCheck" 3/16: "MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check" 5/16:

Hi Samer, Comments included below. Mike

I don't understand this report; with this series applied, line 867 is the following: 867 UINT8 *Src, *Dst; coming from patch v14 37/46, "OvmfPkg/Sec: Add #VC exception handling for Sec

So line 867 of SecMain.c has: UINT8 *Src, *Dst; which appears correct to me, so I believe that is an issue with the tool? I'll fix this. I'll fix this. I'll fix this. I'll fix this. I'm trying

Hi Bret, Sorry for the delayed response. Some more comments here: 1. Currently I see the LockVaribePolicy is called at ReadyToBoot by variable driver, could we update it to be called at EndOfDxe?

I prefer to directly revert the patch. It simplifies the change history.

Can you please explain this in detail? It's ok to not provide the "root" cause of why the image boot behavior is different. Saying the specific issue can help people to understand the issue in

Hi Zhichao, Some patches in this series need reworking. Example - For '[PATCH v3 1/8] ShellPkg/AcpiView: Extract configuration struct' & '[PATCH v3 2/8] ShellPkg/AcpiView: Declutter error

Reminder for review of this series Thanks, --Samer

Thanks Pete. Ard, Leif, If there are no concerns, can you please push this patch, along with the other series that are

It is slight complex, I will review it by 9/11/2020. Thanks.

I will review the patch by next week(8/21). Thanks Guomin

Reviewed-by: Guomin Jiang <guomin.jiang@...> Thanks Guomin

+Hao, Ray, Hi Libo, thanks for your explanation. So I think the patch is improvement for current logic. Hi Hao and Ray, Can you give some comments for the change. Hi Jeremy, It