|
Re: [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.
Hello, Mr. Jiang,
Thank for the review.
The original enumeration steps in the function of UsbEnumerateNewDev of file UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max Packet
Hello, Mr. Jiang,
Thank for the review.
The original enumeration steps in the function of UsbEnumerateNewDev of file UsbEnumer.c: 1 reset the port, 2 set the usb device address, 3 get the Max Packet
|
By
Feng Libo <lbfeng@...>
·
#63981
·
|
|
Re: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR
Ray,
The MBR info is correct. The order change is to avoid the MBR being checked before UDF/ISO 9660 check.
That is why I make the patch #3 in the last of the patch set.
Thanks,
Zhichao
Ray,
The MBR info is correct. The order change is to avoid the MBR being checked before UDF/ISO 9660 check.
That is why I make the patch #3 in the last of the patch set.
Thanks,
Zhichao
|
By
Gao, Zhichao
·
#63980
·
|
|
Re: [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR
I also add some variables to calculate StartingLBA and SizeInLBA instead of calculate them when they are needed.
I am fine to revert the whole changes. Just make you aware of this.
Thanks,
Zhichao
I also add some variables to calculate StartingLBA and SizeInLBA instead of calculate them when they are needed.
I am fine to revert the whole changes. Just make you aware of this.
Thanks,
Zhichao
|
By
Gao, Zhichao
·
#63979
·
|
|
Re: [edk2-wiki][PATCH v2] Update the Boot Guard TOCTOU wiki page.
Hi Guomin,
I'd suggest that you add a section to describe clearly the required steps to
enable this feature in a platform. I just noticed that SecMigrationPei.inf is
not mentioned for doing
Hi Guomin,
I'd suggest that you add a section to describe clearly the required steps to
enable this feature in a platform. I just noticed that SecMigrationPei.inf is
not mentioned for doing
|
By
Wang, Jian J
·
#63978
·
|
|
Re: [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto
How am I supposed to review this change? The commit log is empty and I was not cc'ed on the cover letter.
In general, please try to muster up the energy to write at least one sentence that describes
How am I supposed to review this change? The commit log is empty and I was not cc'ed on the cover letter.
In general, please try to muster up the energy to write at least one sentence that describes
|
By
Ard Biesheuvel
·
#63977
·
|
|
Re: [PATCH v9 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check
Acked-by: Ard Biesheuvel <ard.biesheuvel@...>
Acked-by: Ard Biesheuvel <ard.biesheuvel@...>
|
By
Ard Biesheuvel
·
#63976
·
|
|
Re: [PATCH 3/3] MdeModulePkg/PartitionDxe: Fix the incorrect LBA size in child hander
Reviewed-by: Ray Ni <ray.ni@...>
Reviewed-by: Ray Ni <ray.ni@...>
|
By
Ni, Ray
·
#63975
·
|
|
Re: [PATCH 2/3] MdeModulePkg/PartitionDxe: Remove the check for special MBR
Zhichao,
Can you please just revert the fix you recently added?
Zhichao,
Can you please just revert the fix you recently added?
|
By
Ni, Ray
·
#63974
·
|
|
Re: [PATCH 1/3] MdeModulePkg/PartitionDxe: Put the UDF check ahead of MBR
Zhichao,
Can you also add notes in the commit message describing that for some ISOs (better with more specific ISO info), the MBR information is not correct?
Thanks,
Ray
Zhichao,
Can you also add notes in the commit message describing that for some ISOs (better with more specific ISO info), the MBR information is not correct?
Thanks,
Ray
|
By
Ni, Ray
·
#63973
·
|
|
Re: [PATCH 0/3] MdeModulePkg/PartitionDxe: Make the parition driver match the spec
Thanks for the patches. After applying this patch series, the firmware
recognizes openSUSE/SUSE iso images again.
Tested-by: Gary Lin <glin@...>
Thanks for the patches. After applying this patch series, the firmware
recognizes openSUSE/SUSE iso images again.
Tested-by: Gary Lin <glin@...>
|
By
Gary Lin
·
#63972
·
|
|
[PATCH v9 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Michael D Kinney
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Besides, add submodule path in IgnoreFiles section.
Cc: Michael D Kinney
|
By
Zhang, Shenglei
·
#63971
·
|
|
[PATCH v9 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong <eric.dong@...>
Cc: Ray Ni <ray.ni@...>
Cc:
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong <eric.dong@...>
Cc: Ray Ni <ray.ni@...>
Cc:
|
By
Zhang, Shenglei
·
#63970
·
|
|
[PATCH v9 14/16] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Cc: Zhichao Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Cc: Zhichao Gao
|
By
Zhang, Shenglei
·
#63969
·
|
|
[PATCH v9 13/16] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang
|
By
Zhang, Shenglei
·
#63968
·
|
|
[PATCH v9 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Shenglei Zhang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Shenglei Zhang
|
By
Zhang, Shenglei
·
#63967
·
|
|
[PATCH v9 11/16] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen <jordan.l.justen@...>
Cc: Laszlo Ersek
|
By
Zhang, Shenglei
·
#63966
·
|
|
[PATCH v9 10/16] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda <maciej.rabeda@...>
Cc: Jiaxin Wu
|
By
Zhang, Shenglei
·
#63965
·
|
|
[PATCH v9 09/16] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao
|
By
Zhang, Shenglei
·
#63964
·
|
|
[PATCH v9 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao <liming.gao@...>
Cc: Michael D Kinney
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao <liming.gao@...>
Cc: Michael D Kinney
|
By
Zhang, Shenglei
·
#63963
·
|
|
[PATCH v9 07/16] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Shenglei Zhang
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni <ray.ni@...>
Signed-off-by: Shenglei Zhang
|
By
Zhang, Shenglei
·
#63962
·
|