devel@edk2.groups.io

Re: [PATCH edk2-platforms v2] Silicon/ChaosKeyDxe: don't rely on connect all controllers

I understand the issue. On the fast boot path only things in the NVRAM variables, or hard coded as BDS policy get connected. For example in our custom BDS we have code that connects devices related to

By Andrew Fish · #60677 ·

Re: [PATCH 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Hi, Ray, Thank you very much for making this change. Two minor comments here, - Should we add "EFIAPI" for function GetPciSegmentInfo() since it is standard library interface ? - For ASSERT

By Ma, Maurice <maurice.ma@...> · #60676 ·

Re: [PATCH v5 00/14] Add the VariablePolicy feature

Hi Bret, I don't have any comments on the content of these patches, but I have a couple about metadata: You're submitting the patches from bret@..., but signing them off with Bret Barkelew

By Leif Lindholm <leif@...> · #60675 ·

Re: [PATCH 5/5] Maintainers.txt: Add reviewer for Pei Core.

(1) This section ("MdeModulePkg: Pei Core") should be inserted between: MdeModulePkg: Management Mode (MM, SMM) modules MdeModulePkg: Reset modules With the insertion point fixed: Acked-by: Laszlo

By Laszlo Ersek · #60674 ·

Re: [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

(2) If I remember correctly, we originally wanted the section headers in the Maintainers.txt file to remain alphabetically sorted. This patch would create disorder: SecurityPkg: Tcg related

By Laszlo Ersek · #60673 ·

Re: Where to put RISC-V packages

By Abner Chang · #60672 ·

Re: [PATCH 4/5] Maintainers.txt: Add reviewer for SEC related modules.

Acked-by: Laszlo Ersek <lersek@...>

By Laszlo Ersek · #60671 ·

Re: [PATCH 3/5] Maintainers.txt: Add reviewer for UefiCpuPkg.

Acked-by: Laszlo Ersek <lersek@...>

By Laszlo Ersek · #60670 ·

Re: [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

(1) please replace "security boot" with "secure boot" in the subject. with that fixed: Acked-by: Laszlo Ersek <lersek@...>

By Laszlo Ersek · #60669 ·

Re: [PATCH 1/5] Maintainers.txt: Add reviewers for Tcg related modules.

Acked-by: Laszlo Ersek <lersek@...>

By Laszlo Ersek · #60668 ·

Re: [PATCH v5 08/14] UefiPayloadPkg: Add VariablePolicy engine to UefiPayloadPkg platform

Reviewed-by: Maurice Ma <maurice.ma@...>

By Ma, Maurice <maurice.ma@...> · #60667 ·

Re: [Patch 1/1] [Edk2Platforms] FitGen: Update FitGen tool to be compliance with the FIT specification revision 1.2

Jorge: The patch is good. But, the commit message is too long than 80. Please update the commit message to be short. You can use edk2\BaseTools\Scripts\PatchCheck.py tool to check the patch

By Liming Gao · #60666 ·

Re: [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

Thanks for the ExceptionList / IgnoreFiles features; I think they are really important. I've run ECC in the past, and in some cases it is *way* too strict and opinionated, so I'm sure we'll end up

By Laszlo Ersek · #60665 ·

Re: [PATCH v2 0/2] ArmPkg/PlatformBootManagerLib: add build time checks for serial terminal settings

Pushed as #655 Thanks all.

By Ard Biesheuvel · #60664 ·

Re: [PATCH edk2-InfSpecification] Drop statement on package ordering

I can add this to my queue, sure. I'll get to it sometime. If it's urgent, anyone please feel free to post the patch with the updated wording. Thanks, Laszlo

By Laszlo Ersek · #60663 ·

Re: [PATCH v5 00/14] Add the VariablePolicy feature

meta: Thank you very much for your willingness to learn the mailing list based workflow, even if that workflow is on its way out. I highly appreciate it! Laszlo

By Laszlo Ersek · #60662 ·

Re: [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show inactive boot options

By Gao, Zhichao · #60661 ·

Where to put RISC-V packages

Hi all, (CC edk2 devel ML - shouldn't be a private discussion again) let me try to summarize the points of each: - edk2-platforms isn't a less stable edk2 per se - edk2-platforms can be used for

By Daniel Schaefer · #60660 ·

Re: [PATCH edk2-InfSpecification] Drop statement on package ordering

My wording "edk2-related" was imprecise to the level of being incorrect, apologies for adding confusion. My intended point wast that here is nothing specific about colliding with headers in the edk2

By Leif Lindholm <leif@...> · #60659 ·

Re: [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

May I know the schedule of pushing this change to edk2-master? Or what's next step I should do? Thanks, Walon

By Li, Walon · #60658 ·

Messages