It should simply be renamed. They are not part of the same namespace, it is simply a local hack in CpuDxe to distinguish between valid indexes into the MAIR table and an 'unknown' placeholder

Summary after discussing off-list: This patch isn't *just* moving a public function private, but it's replacing use of a function that was never meant to be public and had a completely bonkers

Hmm, ok. So all of those definitions should really move *out* of ArmPkg/Include/Chipset/AArch64Mmu.h? No, they can't, because some of the others are used

That would imply that this value is somehow architected, which it is not. ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c is the only remaining user of this constant, and it only has meaning within the context

But none of the other consumers of ArmMmuLib do an #include of ArmPkg/Drivers/CpuDxe/CpuDxe.h, right? So I am slightly puzzled by this result.

What I'm saying is that with -Wmissing-prototypes added, building after applying this patch (but before applying the one that deletes the function) gives: "aarch64-linux-gnu-gcc" -g -fshort-wchar

Since this is separately defined also in ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c (£"$%^£"$?!?!?) could this patch be tweaked to instead "consolidate" the definitions to a central location, like

Well, while I see your point, please note that the prototype only exists in a local header file that only gets included by CpuDxe, and not by any of the other consumers of ArmMmuLib.

So, this may be super picky, but: Deleting the prototype without making the definition also STATIC would cause build errors with -Wmissing-prototypes (which someone might be enabling explicitly or

Enhance for check input FD if empty file or not. Cc: Bob Feng <bob.c.feng@...> Cc: Liming Gao <liming.gao@...> Signed-off-by: Yunhua Feng <yunhuax.feng@...> ---

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2655 This patch fixes reversed logic of recently added ASSERTs which should ensure that Ip6IsNDOptionValid() implementation properly reacts to

Summarize the issue, if anything incorrect, please help to correct it. Thanks. Background: Uefi spec ambiguous description: > When interpreting the data from this function, it should be noted

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2656 1. Add GetPackagesPath.py, it will be used to get package pathes from special directories. A sub directory is a qualified package path

Use submodule way to access oniguruma. And upgrade oniguruma version from v6.9.3 to v6.9.4_mark1. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2073 Cc: Jian J Wang <jian.j.wang@...> Cc:

Hi Micheal Rothman, Can you help to review this issue? Because of the uefi spec issue, some firmware implemented the different behavior. Should the edk2 code to handle such issue? If yes, here

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Erik, Please remember to Cc: the reviewers on the cover letter as well next time. For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@...>

Hi All, We have a build failure with VS2012(https://bugzilla.tianocore.org/show_bug.cgi?id=2631). If no body uses VS2012, I would like to ignore this issue. I send this mail to collect

With Laszlo's comments. Reviewed-by: Siyuan Fu <siyuan.fu@...>