devel@edk2.groups.io

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

Good point. I will send out a v2 tomorrow

By Ard Biesheuvel · #485 ·

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

ard, i think you need to have R_X86_64_PLT32 case in WriteRelocations64. without that, i still hit the invalid relocation message.

By Nicolas Owens <mischief@...> · #484 ·

Managing GCC Assembly Code Size (AArch64)

Ard and Leif, I've been too backlogged to provide a real patchset at this point but wanted to get your approval on this proposal... As you know we have some code size sensitive uncompressed XIP

By Cohen, Eugene <eugene@...> · #483 ·

Re: [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags

not directly related but could we add nostdinc too? At least for my platform that works perfectly and it prevents you from accidentally including any libc/libgcc/whatever headers from your

By Michael Zimmermann · #482 ·

[PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags

Avoid build errors when including OpensslLib, which may throw undefined reference errors for builtin functions if -fno-builtin is not specified (and it is already set for IA32, X64 and AARCH64) So set

By Ard Biesheuvel · #481 ·

[PATCH 2/3] ArmPkg/CompilerIntrinsicsLib: make the default memset() weak

The ARM compiler intrinsics library defines __aeabi_memset() and memset() in the same object, which means that both will be pulled in if either is referenced. The IntrinsicLib in CryptoPkg defines

By Ard Biesheuvel · #480 ·

[PATCH 1/3] ArmPkg/ArmSoftFloatLib: disable LTO build for GCC

Building ArmSoftFloatLib with LTO results in errors like .../bin/ld: softfloat.obj: plugin needed to handle lto object .../bin/ld: __aeabi_dcmpge.obj: plugin needed to handle lto object

By Ard Biesheuvel · #479 ·

[PATCH 0/3] Build fixes for ARM/OpenSSL

This series addresses some issues that cause the build to be broken for ARM GCC5 at the moment when including OpensslLib in the build. Ard Biesheuvel (3): ArmPkg/ArmSoftFloatLib: disable LTO build

By Ard Biesheuvel · #478 ·

Re: [PATCH] PcdBdsLinuxSupport default value

Reviewed-by: Leif Lindholm <leif.lindholm@...> Pushed (with a tweak to the subject line), thanks!

By Leif Lindholm <leif.lindholm@...> · #477 ·

Re: [PATCH 3/3] SecurityPkg Tcg2: Remove internal implementation of IsZeroBuffer()

Reviewed-by: Chao Zhang<chao.b.zhang@...> Thanks & Best regards Chao Zhang

By Zhang, Chao B <chao.b.zhang@...> · #476 ·

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

Did you read the elaborate comment block explaining that (and why) it is appropriate to treat R_X86_64_PLT32 as a R_X86_64_PC32 relocation? This is not generally true, but it is true for UEFI since we

By Ard Biesheuvel · #475 ·

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

OK, it is. But it is a bit not very clear. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522

By Shi, Steven <steven.shi@...> · #474 ·

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

Isn't it identical to the code for R_X86_64_PC32?

By Ard Biesheuvel · #473 ·

Re: [PATCH] BaseTools X64: fold PLT relocations into simple relative references

Hi Ard, I don't see you add below code for case R_X86_64_PLT32. Is it right? *(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ + (mCoffSectionsOffset[Sym->st_shndx] -

By Shi, Steven <steven.shi@...> · #472 ·

[PATCH] BaseTools X64: fold PLT relocations into simple relative references

For X64/GCC, we use position independent code with hidden visibility to inform the compiler that symbols references are never resolved at runtime, which removes the need for PLTs and GOTs. However, in

By Ard Biesheuvel · #471 ·

Re: [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

By Wu, Hao A · #470 ·

Re: [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

Hello Hao, (1) Do you plan to add optimized implementations of IsZeroBuffer() later on? For example, in QEMU, the buffer_is_zero() function has optimized implementations for: - AVX2 - SSE2 -

By Laszlo Ersek · #469 ·

[PATCH 3/3] SecurityPkg Tcg2: Remove internal implementation of IsZeroBuffer()

This commit removes the internal implementation of the function IsZeroBuffer(). Instead, it will use the one from BaseMemoryLib. Cc: Jiewen Yao <jiewen.yao@...> Cc: Chao Zhang

By Wu, Hao A · #468 ·

[PATCH 2/3] MdePkg BaseMemoryLib: Add implementation of API IsZeroBuffer()

Cc: Michael D Kinney <michael.d.kinney@...> Cc: Liming Gao <liming.gao@...> Cc: Jiewen Yao <jiewen.yao@...> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao

By Wu, Hao A · #467 ·

[PATCH 1/3] MdePkg BaseMemoryLib: Add implementation of API IsZeroGuid()

Cc: Michael D Kinney <michael.d.kinney@...> Cc: Liming Gao <liming.gao@...> Cc: Jiewen Yao <jiewen.yao@...> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao

By Wu, Hao A · #466 ·

Messages