Sorry this one was intended for patch 6 not patch 5.

Hello, I initially raised this question in a new TimerLib patch[1], but as the discussion was getting more distracted, I decided to create a separate thread in hopes new people could join. The issue

Hi David, Here are my comments: 1. All of the copyright years need to be updated to 2019. 2. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0" from your commit message as it

Hi David, Here are my comments: 1. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0" from your commit message as it is no longer needed. 2. Please don't add this entry:

Hi David, Here are my comments: 1. What is the purpose of this driver? My guess this is just a dummy driver that provides the EFI_SIO_PROTOCOL and does resource management without actually accessing

Hi David, Here are my comments: 1. All of the copyright years need to be updated to 2019. 2. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0" from your commit message as it

Vitaly, When implementing a UEFI Application, if you want maximum compatibility, you should use UEFI Services/Protocols and minimize as many HW assumptions as possible. I understand,

Laszlo Ersek <lersek@...> wrote: it shouldn't matter where from management SMI comes if OS won't be able to actually trigger SMI with un-trusted content at SMBASE on hotplugged (parked)

Reviewed-by: Michael D Kinney <michael.d.kinney@...> Mike

Paolo Bonzini <pbonzini@...> wrote: Looking at Q35 code and Seabios SMM relocation as example, if I see it right QEMU has: - SMRAM is aliased from DRAM at 0xa0000 - and TSEG steals

The BSP starts running from 0xFFFFFFF0. APs do not start running at all and just sit waiting for an INIT-SIPI-SIPI sequence. Please see my proposal in the reply to Laszlo. Paolo

I was going through the steps Jiewen and Yingwen recommended. In step (02), the new CPU is expected to set up RAM access. In step (03), the new CPU, executing code from flash, is expected to "send

From: "Shi, Steven" <steven.shi@...> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2079 The Basetool CopyFileOnChange() and SaveFileOnChange() functions might raise the IOError

From: "Shi, Steven" <steven.shi@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923 Fix the issue that the GenFds multi-thread will build fail if enable the build cache together. Cc:

From: "Shi, Steven" <steven.shi@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951 Current build cache use the module's [self.Arch][self.Name] info as the ModuleAutoGen object key in

From: "Shi, Steven" <steven.shi@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925 When a module build cache miss, add support to print the first cache missing file path and

From: "Shi, Steven" <steven.shi@...> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1927 Current cache hash algorithm does not parse and generate the makefile to get the accurate

From: "Shi, Steven" <steven.shi@...> This patch set is for the 201908 stable tag Enhance the edk2 build cache with below patches: Patch 01/05: Improve the cache hit rate through new cache

Check if global (in the scope of the DBG2 parser) pointers have been successfully updated before they are used for further table parsing. Signed-off-by: Krzysztof Koch

Check if the MadtInterruptControllerType and MadtInterruptControllerLength pointers have been successfully updated before they are used for further table parsing. Signed-off-by: Krzysztof Koch