Leif: I agree to discuss the behavior first, then review the code logic in detail. I add my comments below.

The new VS2012 build failure is caused by 7a0df26. xxx\registercpufeatureslib\dxeregistercpufeatureslib.c(258) : warning C4701: potentially uninitialized local variable 'MpEvent' used It is a false

Add subject prefix [edk2-test] for better sorting

Rebecca: The change is good. Reviewed-by: Liming Gao <liming.gao@...> for 1-4, and 6. For patch 5, I see Leif sends another version update. I will give the comments on his change.

Forward to devel@edk2.groups.io with public review.

Forward to devel@edk2.groups.io with public review.

From: "Dong, Eric" <eric.dong@...> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 Function in this library may be used by APs. Assert will be trig if AP uses dynamic pcd. This patch

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1972 AP calls CollectProcessorData() to collect processor info. CollectProcessorData function finally calls PcdGetSize function to get DynamicPCD

V3 Changes: 1. Remove IsCpuFeatureMatch function. V2 Changes: 1. Revert IsBitMaskMatchCheck change which is not correct. 2. refine some variable name. v1 changes: REF:

This commit add the reviewers information for modules within MdeModulePkg. For now the modules list includes: ACPI BDS Console and Graphic Core services (PEI, DXE and Runtime) Device and

This patch is also available at: https://github.com/hwu25/edk2/tree/mdemodulepkg_reviewers Also, please note that on the above branch, the proposed patch (MdeModulePkg reviewers) is inserted

Reviewed-by: Liming Gao <liming.gao@...>

Reviewed-by: Rebecca Cran <rebecca@...>

The EDK II C Coding Standards Specification (v2.20) strongly discourages variable declarations in nested block scope: 5 Source Files 5.4 Code File Structure 5.4.1 Scoping Rules 5.4.1.1

It was rejected, with a message saying "Your account is bouncing. Please visit the web site to unbounce your account." I have just done so. I did wonder if it actually meant that its email to me was

Likewise. Yes. And in fact this is one of the things I found problematic (but not seriously so) with the functionality that is currently in the tree. Yes, but likewise, a system may have more

Thank you all for the feedback! * Added a paragraph to the commit message of patch#2, as requested by Phil, based on the discussion with Marvin: + The intent is to only strengthen the

Hi David, something must have gone wrong -- I don't see your message in my list folder, and I haven't received a moderation request either. Do you have an idea why your message may not have reached

Hi Leif, I think I'd be fine, personally, with this change. It's still a behavioral change in two aspects, and so I'd like the BaseTools maintainers to comment on those: (1) If I understand