|
Re: [PATCH 1/2] BaseTools/GenFw AARCH64: convert ADRP to ADR if binary size allows it
@Liming, @Leif:
are there any objections to these patches? I know it is unfortunate
that we need to modify instructions as part of the ELF to PE/COFF
conversion, but it is very
@Liming, @Leif:
are there any objections to these patches? I know it is unfortunate
that we need to modify instructions as part of the ELF to PE/COFF
conversion, but it is very
|
By
Ard Biesheuvel
·
#259
·
|
|
[PATCH] IntelFsp2Pkg: Locate FSP Info Header dynamically
we need to locate the FSP Info Header by calculating offset dynamically to
handle the scenario of FSP component is being rebased to different location.
Cc: Maurice Ma <maurice.ma@...>
Cc:
we need to locate the FSP Info Header by calculating offset dynamically to
handle the scenario of FSP component is being rebased to different location.
Cc: Maurice Ma <maurice.ma@...>
Cc:
|
By
Satya Yarlagadda <satya.p.yarlagadda@...>
·
#258
·
|
|
[patch 2/2] BaseTools/VfrCompile: Add two new option for VfrCompile
1.--autodefault option
VfrCompile will generate default opcodes for questions if some
default are missing.
2 --checkdefault option
VfrCompile will check whether every question has no default
1.--autodefault option
VfrCompile will generate default opcodes for questions if some
default are missing.
2 --checkdefault option
VfrCompile will check whether every question has no default
|
By
Dandan Bi
·
#257
·
|
|
[patch 1/2] BaseTool/VfrCompile: Add missing question opcode
The function CheckQuestionOpCode is to check whether the opcode
is question opcode, but it misses two question opcodes:
'EFI_IFR_REF_OP' and 'EFI_IFR_RESET_BUTTON'. Now add them.
Cc: Liming Gao
The function CheckQuestionOpCode is to check whether the opcode
is question opcode, but it misses two question opcodes:
'EFI_IFR_REF_OP' and 'EFI_IFR_RESET_BUTTON'. Now add them.
Cc: Liming Gao
|
By
Dandan Bi
·
#256
·
|
|
[patch 0/2] BaseTools/VfrCompile: Add two new option for VfrCompile
patch 1 is to fix a bug in current code.
patch 2 is to add two compile option for VfrCompile.
Cc: Liming Gao <liming.gao@...>
Cc: Eric Dong <eric.dong@...>
Contributed-under: TianoCore
patch 1 is to fix a bug in current code.
patch 2 is to add two compile option for VfrCompile.
Cc: Liming Gao <liming.gao@...>
Cc: Eric Dong <eric.dong@...>
Contributed-under: TianoCore
|
By
Dandan Bi
·
#255
·
|
|
Re: [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code
(adding back our friends on cc)
CoffAddFixup() must be used for absolute symbol references only. These
instructions contain relative symbol references, which are
recalculated in
(adding back our friends on cc)
CoffAddFixup() must be used for absolute symbol references only. These
instructions contain relative symbol references, which are
recalculated in
|
By
Ard Biesheuvel
·
#254
·
|
|
Re: [RFC 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support
(Apologies, missed out on this branch of the thread on first pass
since I was dropped from cc.)
Since I was not certain of how this was historically, or should in the
future, be interpreted I left
(Apologies, missed out on this branch of the thread on first pass
since I was dropped from cc.)
Since I was not certain of how this was historically, or should in the
future, be interpreted I left
|
By
Leif Lindholm <leif.lindholm@...>
·
#253
·
|
|
Re: [patch] NetworkPkg: Fix assert issue in iSCSI driver
Reviewed-by: Fu Siyuan <siyuan.fu@...>
Reviewed-by: Fu Siyuan <siyuan.fu@...>
|
By
Siyuan, Fu
·
#252
·
|
|
Re: [patch] NetworkPkg: Fix assert issue in iSCSI driver
Reviewed-by: Ye Ting <ting.ye@...>
Reviewed-by: Ye Ting <ting.ye@...>
|
By
Ye, Ting <ting.ye@...>
·
#251
·
|
|
[patch] NetworkPkg: Fix assert issue in iSCSI driver
The bug is caused by using already freed memory.
If there is already an attempt and execute
'reconnect -r' command, all the AttemptConfig structure
will be freed, but the mCallbackInfo->Current is
The bug is caused by using already freed memory.
If there is already an attempt and execute
'reconnect -r' command, all the AttemptConfig structure
will be freed, but the mCallbackInfo->Current is
|
By
Zhang Lubo <lubo.zhang@...>
·
#250
·
|
|
Re: [RFC 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support
I don't object to using UINTN and UINT64 interchangeably in a file
that is specific to an architecture where they resolve to the same
thing.
The thunking code is a bit clunky, and tries to deal with
I don't object to using UINTN and UINT64 interchangeably in a file
that is specific to an architecture where they resolve to the same
thing.
The thunking code is a bit clunky, and tries to deal with
|
By
Ard Biesheuvel
·
#249
·
|
|
Re: [PATCH v2 2/7] BaseTools-GenFw:Add new x86_64 Elf relocation types for PIC/PIE code
[Steven]: In this example, the pie.o is just the object file which is not linked. And if you link this pie.o file, the linker will solve all these three R_X86_64_REX_GOTP symbol with same 'int n'
[Steven]: In this example, the pie.o is just the object file which is not linked. And if you link this pie.o file, the linker will solve all these three R_X86_64_REX_GOTP symbol with same 'int n'
|
By
Shi, Steven <steven.shi@...>
·
#248
·
|
|
Re: [RFC 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support
Hi Feng,
For the record, http://opensource.org/licenses/bsd-license.php is the
same as http://opensource.org/licenses/BSD-2-Clause.
Which is mentioned explicitly under point 5 of the
Hi Feng,
For the record, http://opensource.org/licenses/bsd-license.php is the
same as http://opensource.org/licenses/BSD-2-Clause.
Which is mentioned explicitly under point 5 of the
|
By
Leif Lindholm <leif.lindholm@...>
·
#247
·
|
|
Re: [PATCH] add top-level .gitattributes file, dealing with .depex
While I don't disagree, the PI dependency expression instruction set
(section 10.7, PI spec 1.4 vol2) does not look Turing complete to me.
Meaning it's "binary" in much the same way a .uni file
While I don't disagree, the PI dependency expression instruction set
(section 10.7, PI spec 1.4 vol2) does not look Turing complete to me.
Meaning it's "binary" in much the same way a .uni file
|
By
Leif Lindholm <leif.lindholm@...>
·
#246
·
|
|
[PATCH v5 8/8] BaseTools GCC: introduce GCC5 toolchain to support GCC v5.x in LTO mode
This adds support for GCC 5.x in LTO mode for IA32, X64, ARM and
AARCH64. Due to the fact that the GCC project switched to a new
numbering scheme where the first digit is now incremented for
This adds support for GCC 5.x in LTO mode for IA32, X64, ARM and
AARCH64. Due to the fact that the GCC project switched to a new
numbering scheme where the first digit is now incremented for
|
By
Ard Biesheuvel
·
#245
·
|
|
[PATCH v5 7/8] MdePkg GCC/X64: avoid 'hidden' visibility for module entry points
When building with LTO enabled, the LTO routines infer from the 'hidden'
visibility of the _ModuleEntryPoint symbol that its code only needs to be
retained if it is referenced internally, and
When building with LTO enabled, the LTO routines infer from the 'hidden'
visibility of the _ModuleEntryPoint symbol that its code only needs to be
retained if it is referenced internally, and
|
By
Ard Biesheuvel
·
#244
·
|
|
[PATCH v5 6/8] BaseTools GCC: drop GNU notes section from EFI image
Recent versions of GNU ld automatically emit a .notes section into
the ELF binary containing a build id. Since this is an allocatable
section by default, it will be identified by GenFw as a
Recent versions of GNU ld automatically emit a .notes section into
the ELF binary containing a build id. Since this is an allocatable
section by default, it will be identified by GenFw as a
|
By
Ard Biesheuvel
·
#243
·
|
|
[PATCH v5 5/8] ArmPkg: add prebuilt glue binaries for GCC5 LTO support
GCC in LTO mode interoperates poorly with non-standard libraries that
provide implementations of compiler intrinsics such as memcpy/memset
or the stack protector entry points. Such libraries need to
GCC in LTO mode interoperates poorly with non-standard libraries that
provide implementations of compiler intrinsics such as memcpy/memset
or the stack protector entry points. Such libraries need to
|
By
Ard Biesheuvel
·
#242
·
|
|
[PATCH v5 4/8] BaseTools GCC: use 'gcc' as the linker command for GCC44 and later
To accommodate upcoming GCCx toolchain versions that require 'gcc' to
be used as the linker in order to support LTO, switch GCC44 and later
(including CLANG35) to a new DLINK build rule that invokes
To accommodate upcoming GCCx toolchain versions that require 'gcc' to
be used as the linker in order to support LTO, switch GCC44 and later
(including CLANG35) to a new DLINK build rule that invokes
|
By
Ard Biesheuvel
·
#241
·
|
|
[PATCH v5 3/8] BaseTools UNIXGCC ELFGCC CYGGCC: clone GCC build rule family into GCCLD
Before we can make non-backward compatible changes to the GCC build rules
regarding the use of the 'gcc' binary as the linker, clone the existing
GCC build rules into a 'GCCLD' build rule family, and
Before we can make non-backward compatible changes to the GCC build rules
regarding the use of the 'gcc' binary as the linker, clone the existing
GCC build rules into a 'GCCLD' build rule family, and
|
By
Ard Biesheuvel
·
#240
·
|