The HDiskImageSave() function copies a device path using DuplicateDevicePath() and passes that device path to gBS->LocateDevicePath() that changes the value of the device path pointer. When

Can we link the Readme.MD to platform specific readmes via hyperlinks, or at list relative path to the other files.? Thanks, Andrew Fish

Hi Mike, I'm happy with the proposal in this state, but have a few suggested updates (mostly to clarify that, long term, we expect most platforms to exist in master) and a small suggested

Star, I think the comment should be updated. This updated algorithm only uses the lower 24-bits of the ACPI timer. It is compatible with both 24-bit and 32-bit ACPI timers. Mike

Jiewen, I will review the Quark specific changes today. Mike

It looks like MdeModulePkg/Include/Protocol/PlatformLogo.h contains the definition of IMAGE_FORMAT and it is an enum. It should be included by

Hi, Everyone. My machine is a Intel P6200 cpu, no vt-x support, 64bit, Debian 8 64bit OS. I am compiling EDK2 with the instruction at:

Reviewed-by: Laszlo Ersek <lersek@...> Thanks! Laszlo

Jiewen, Thanks for the Rb, I just send the V2 patch that follows Laszlo's suggestion to use IoBitFieldRead32 (Port, 0, 23), could you help review the patch again? Star

Laszlo, I agree that is a better idea, please check the V2 patch. Thanks, Star

From: "Zeng, Star" <star.zeng@...> Clear bits [31:24] when reading ACPI timer count by IoRead32(), also add comments "Note: The library only supports 24Bits ACPI timer" in INF. Cc: Jiewen Yao

Reviewed-by: jiewen.yao@...

Star, Just a question: would the IoBitFieldRead32() function apply in this case? If it is applicable, then I think it could make the code easier to read: IoBitFieldRead32 (Port, 0, 23) Just an

Clear bits [31:24] when reading ACPI timer count by IoRead32(), also add comments "Note: The library only supports 24Bits ACPI timer" in INF. Cc: Jiewen Yao <jiewen.yao@...> Cc: Liming Gao

Reviewed-by: Liming Gao <liming.gao@...>

Reviewed-by: Liming Gao <liming.gao@...>

Reviewed-by: Jeff Fan <jeff.fan@...>

Hi I got reviewed-by for MdeModulePkg/SecurityPkg/UefiCpuPkg/Vlv2DevicePkg. Thanks each package owner. I have not got reviewed-by for QuarkPlatformPkg yet. Can QuarkPlatformPkg owner review the

Jiewen: SecurityPackage Patches are good to me. Reviewed by : Chao Zhang <chao.b.zhang@...> Thanks & Best regards Chao Zhang

Hi Brian, This is a good idea. I will have to study it some more to figure out what the EBC versions of these macros would map to. Mike