Date   

[PATCH V2 1/1] OvmfPkg/OvmfPkgX64: Adjust load sequence of TdxDxe and AmdSevDxe driver

Min Xu
 

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3904

TdxDxe driver is introduced for Intel TDX feature. Unfortunately, this
driver also breaks boot process in SEV-ES guest. The root cause is in
the PciLib which is imported by TdxDxe driver.

In a SEV-ES guest the AmdSevDxe driver performs a
MemEncryptSevClearMmioPageEncMask() call against the
PcdPciExpressBaseAddress range to mark it shared/unencrypted. However,
the TdxDxe driver is loaded before the AmdSevDxe driver, and the PciLib
in TdxDxe is DxePciLibI440FxQ35 which will access the
PcdPciExpressBaseAddress range. Since the range has not been marked
shared/unencrypted, the #VC handler terminates the guest for trying to
do MMIO to an encrypted region.

Adjusting the load sequence of TdxDxe and AmdSevDxe can fix the issue.

Cc: Brijesh Singh <brijesh.singh@...>
Cc: Erdem Aktas <erdemaktas@...>
Cc: James Bottomley <jejb@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Tom Lendacky <thomas.lendacky@...>
SEV-Tested-by: Tom Lendacky <thomas.lendacky@...>
TDX-Tested-by: Min Xu <min.m.xu@...>
Signed-off-by: Min Xu <min.m.xu@...>
---
OvmfPkg/OvmfPkgX64.fdf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf
index 71df28705ea8..1f9d0b3f5fcc 100644
--- a/OvmfPkg/OvmfPkgX64.fdf
+++ b/OvmfPkg/OvmfPkgX64.fdf
@@ -214,8 +214,8 @@ READ_LOCK_STATUS = TRUE
APRIORI DXE {
INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf
INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf
- INF OvmfPkg/TdxDxe/TdxDxe.inf
INF OvmfPkg/AmdSevDxe/AmdSevDxe.inf
+ INF OvmfPkg/TdxDxe/TdxDxe.inf
!if $(SMM_REQUIRE) == FALSE
INF OvmfPkg/QemuFlashFvbServicesRuntimeDxe/FvbServicesRuntimeDxe.inf
!endif
--
2.29.2.windows.2


[PATCH] ShellPkg: Update smbiosview type 0 with SMBIOS 3.5 fields

Bo Chang Ke
 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3906

update smbiosview type 0 related fileds.

Signed-off-by: Bo Chang Ke <bo-changx.ke@...>
Cc: Ray Ni <ray.ni@...>
Cc: Zhichao Gao <zhichao.gao@...>
---
.../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 6 ++++++
.../SmbiosView/SmbiosViewStrings.uni | 2 ++
2 files changed, 8 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b144600a25..618bcd1590 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -1536,6 +1536,12 @@ DisplayBiosCharacteristicsExt2 (
if (BIT (byte2, 4) != 0) {
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_VIRTUAL_MACHINE), gShellDebug1HiiHandle);
}
+ if (BIT (byte2, 5) != 0) {
+ ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_MCFG_SUPPORTED), gShellDebug1HiiHandle);
+ }
+ if (BIT (byte2, 6) != 0) {
+ ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_MCFG_ENABLED), gShellDebug1HiiHandle);
+ }

ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BITS_RSVD_FOR_FUTURE), gShellDebug1HiiHandle, 5);
} else {
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
index 9433e8a25f..5a83e9834b 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/SmbiosViewStrings.uni
@@ -163,6 +163,8 @@
#string STR_SMBIOSVIEW_PRINTINFO_ENABLE_TAR_CONT_DIST #language en-US "Enable Targeted Content Distribution\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_UEFI_SPEC_SUPPORT #language en-US "UEFI Specification is supported\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_VIRTUAL_MACHINE #language en-US "The SMBIOS table describes a virtual machine\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_MCFG_SUPPORTED #language en-US "Manufacturing mode is supported\r\n"
+#string STR_SMBIOSVIEW_PRINTINFO_MCFG_ENABLED #language en-US "Manufacturing mode is enabled\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_BITS_RSVD_FOR_FUTURE #language en-US " Bits %d:7 are reserved for future assignment\r\n"
#string STR_SMBIOSVIEW_PRINTINFO_PROCESSOR_FAMILY #language en-US "Processor Family: "
#string STR_SMBIOSVIEW_PRINTINFO_OTHER #language en-US "Other\r\n"
--
2.32.0.windows.1


Re: EDK2 WilsonCityRVP BIOS Build Error

Akber Basha J
 

Hello Nate,

Thank you for your response.

Build is still getting failed after trying the steps you have mentioned.

Regards,
Akber



---- On Mon, 11 Apr 2022 23:14:14 +0530 Desimone, Nathaniel L <nathaniel.l.desimone@...> wrote ----

Hi Akber,

 

It looks like you are trying to build without using the MinPlatform build script. Please try building using the following:

 

cd edk2

source edksetup.sh

cd ../edk2-platforms/Platform/Intel

python ./build_bios.py -p WilsonCityRvp

 

Thanks,

Nate

 

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Akber Basha J via groups.io <akberbasha.j=zohocorp.com@groups.io>
Date: Monday, April 11, 2022 at 4:38 AM
To: devel <devel@edk2.groups.io>
Cc: Sadafale, Mangesh <mangesh.s@...>
Subject: [edk2-devel] EDK2 WilsonCityRVP BIOS Build Error

Team,

 

We are getting build errors while trying to build BIOS for Intel WilsonCityRVP under WhitleyOpenBoardPkg platform.

 

Toolchains used:

GCC: 5 and 7 (getting same error for both GCC5 and GCC7)

IASL: 20211217

OS: Ubuntu-20.04-LTS

Source: Latest EDK2 "master" source is being used for compilation.

 

All pre-build tests has been run successfully.

 

With the above-mentioned toolchains, we could successfully able to build BIOS images for TigerlakeURVP platform. But for WhitleyOpenBoardPkg, errors are thrown.

 

Error screenshot has been attached with this mail for reference.

 


 

Any help would be appreciated.

 

Regards,

Akber

 





Re: EDK2 WilsonCityRVP BIOS Build Error

Akber Basha J
 


Team,

Any help/support available on this WilsonCityRvp BIOS build issue?

Regards,
Akber



---- On Mon, 11 Apr 2022 17:08:26 +0530 Akber Basha J <akberbasha.j@...> wrote ----

Team,

We are getting build errors while trying to build BIOS for Intel WilsonCityRVP under WhitleyOpenBoardPkg platform.

Toolchains used:
GCC: 5 and 7 (getting same error for both GCC5 and GCC7)
IASL: 20211217
OS: Ubuntu-20.04-LTS
Source: Latest EDK2 "master" source is being used for compilation.

All pre-build tests has been run successfully.

With the above-mentioned toolchains, we could successfully able to build BIOS images for TigerlakeURVP platform. But for WhitleyOpenBoardPkg, errors are thrown.

Error screenshot has been attached with this mail for reference.



Any help would be appreciated.

Regards,
Akber




[PATCH 1/1] CryptoPkg/Crt: fix strcpy build on older VS compilers

Gerd Hoffmann
 

Drop 'restrict' keyword which older visual studio compiler
versions complain about.

Fixes: fab6285a73c4 ("CryptoPkg/CrtLibSupport: fix strcpy")
Signed-off-by: Gerd Hoffmann <kraxel@...>
---
CryptoPkg/Library/Include/CrtLibSupport.h | 4 ++--
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
index bdc2654b6eef..e49060124ff6 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -397,8 +397,8 @@ inet_pton (

char *
strcpy (
- char *restrict strDest,
- const char *strSource
+ char *strDest,
+ const char *strSource
);

//
diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 6fcbe5885e7b..c1fc33538f9b 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -267,8 +267,8 @@ strcspn (

char *
strcpy (
- char *restrict strDest,
- const char *strSource
+ char *strDest,
+ const char *strSource
)
{
AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource);
--
2.35.1


[Patch V2] CryptoPkg: Fix the build failure in CryptoPkg

duntan
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908

Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy")
Remove the 'restrict' keyword which starts in VS2019.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyu1.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
---
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 ++--
CryptoPkg/Library/Include/CrtLibSupport.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 6fcbe5885e..c1fc33538f 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -267,8 +267,8 @@ strcspn (

char *
strcpy (
- char *restrict strDest,
- const char *strSource
+ char *strDest,
+ const char *strSource
)
{
AsciiStrCpyS (strDest, MAX_STRING_SIZE, strSource);
diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
index bdc2654b6e..e49060124f 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -397,8 +397,8 @@ inet_pton (

char *
strcpy (
- char *restrict strDest,
- const char *strSource
+ char *strDest,
+ const char *strSource
);

//
--
2.31.1.windows.1


Re: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg

duntan
 

Hi,
I tested it locally. I just created a PR. Here is the link
https://github.com/tianocore/edk2/pull/2800

Thanks,
Dun

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@...>
Sent: Wednesday, April 20, 2022 11:40 AM
To: Tan, Dun <dun.tan@...>; devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@...>; Lu, Xiaoyu1 <xiaoyu1.lu@...>; Jiang, Guomin <guomin.jiang@...>
Subject: RE: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg

Hi
May I know if you have run EDKII CI for this patch?

-----Original Message-----
From: Tan, Dun <dun.tan@...>
Sent: Wednesday, April 20, 2022 11:35 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@...>; Wang, Jian J
<jian.j.wang@...>; Lu, Xiaoyu1 <xiaoyu1.lu@...>; Jiang,
Guomin <guomin.jiang@...>
Subject: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908

Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy") Remove the
'restrict' keyword which starts in VS2019.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyu1.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
---
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 2 +-
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 6fcbe5885e..68e21e8fb6 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -267,7 +267,7 @@ strcspn (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
)
{
diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h
b/CryptoPkg/Library/Include/CrtLibSupport.h
index bdc2654b6e..bce38eaa1a 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -397,7 +397,7 @@ inet_pton (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
);

--
2.31.1.windows.1


Re: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg

Yao, Jiewen
 

Hi
May I know if you have run EDKII CI for this patch?

-----Original Message-----
From: Tan, Dun <dun.tan@...>
Sent: Wednesday, April 20, 2022 11:35 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@...>; Wang, Jian J <jian.j.wang@...>;
Lu, Xiaoyu1 <xiaoyu1.lu@...>; Jiang, Guomin <guomin.jiang@...>
Subject: [PATCH] CryptoPkg: Fix the build failure in CryptoPkg

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908

Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy")
Remove the 'restrict' keyword which starts in VS2019.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyu1.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
---
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 2 +-
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 6fcbe5885e..68e21e8fb6 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -267,7 +267,7 @@ strcspn (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
)
{
diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h
b/CryptoPkg/Library/Include/CrtLibSupport.h
index bdc2654b6e..bce38eaa1a 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -397,7 +397,7 @@ inet_pton (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
);

--
2.31.1.windows.1


[PATCH] CryptoPkg: Fix the build failure in CryptoPkg

duntan
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3908

Fix the build failure in CryptoPkg caused by this commit:
fab6285a73("CryptoPkg/CrtLibSupport: fix strcpy")
Remove the 'restrict' keyword which starts in VS2019.

Signed-off-by: Dun Tan <dun.tan@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Xiaoyu Lu <xiaoyu1.lu@...>
Cc: Guomin Jiang <guomin.jiang@...>
---
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 2 +-
CryptoPkg/Library/Include/CrtLibSupport.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
index 6fcbe5885e..68e21e8fb6 100644
--- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
+++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c
@@ -267,7 +267,7 @@ strcspn (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
)
{
diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h
index bdc2654b6e..bce38eaa1a 100644
--- a/CryptoPkg/Library/Include/CrtLibSupport.h
+++ b/CryptoPkg/Library/Include/CrtLibSupport.h
@@ -397,7 +397,7 @@ inet_pton (

char *
strcpy (
- char *restrict strDest,
+ char *strDest,
const char *strSource
);

--
2.31.1.windows.1


Re: [PATCH v3 0/8] CryptoPkg updates for openssl 3.0

Yao, Jiewen
 

Hi Gerd
Do you have any comment for the regression issue?

I think we should remove "restrict" keyword.

Thank you
Yao Jiewen

-----Original Message-----
From: Tan, Dun <dun.tan@...>
Sent: Tuesday, April 19, 2022 5:27 PM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@...>; Gerd
Hoffmann <kraxel@...>
Cc: Oliver Steffen <osteffen@...>; Pawel Polawski
<ppolawsk@...>; Wang, Jian J <jian.j.wang@...>; Xiaoyu Lu
<xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>; Liu,
Zhiguang <zhiguang.liu@...>; Zeng, Star <star.zeng@...>
Subject: RE: [edk2-devel] [PATCH v3 0/8] CryptoPkg updates for openssl 3.0

Hi Hoffmann,

When building CryptoPkg, I found a build failure caused by this patch "
CryptoPkg/CrtLibSupport: fix strcpy"
https://github.com/tianocore/edk2/commit/fab6285a73c4c73bb131792d0afb2
0be369082d1.
When building CryptoPkg with the command " build -p CryptoPkg/CryptoPkg.dsc
-b DEBUG -t VS2015x86 -a IA32 -a X64 ", it failed with the following log:
c:\code\edk2\edk2\CryptoPkg\Library\Include\CrtLibSupport.h(400): error
C2146: syntax error: missing ')' before identifier 'strDest'
c:\code\edk2\edk2\CryptoPkg\Library\Include\CrtLibSupport.h(400): error
C2061: syntax error: identifier 'strDest'
c:\code\edk2\edk2\CryptoPkg\Library\Include\CrtLibSupport.h(400): error
C2059: syntax error: ';'
c:\code\edk2\edk2\CryptoPkg\Library\Include\CrtLibSupport.h(400): error
C2059: syntax error: ','
c:\code\edk2\edk2\CryptoPkg\Library\Include\CrtLibSupport.h(402): error
C2059: syntax error: ')'

I guess the root cause is the "restrict" keyword in this patch is not supported by
VS2015.
Can you please to fix this issue?

Thanks,
Dun
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen
Sent: Tuesday, April 12, 2022 10:41 PM
To: Gerd Hoffmann <kraxel@...>; devel@edk2.groups.io
Cc: Oliver Steffen <osteffen@...>; Pawel Polawski
<ppolawsk@...>; Wang, Jian J <jian.j.wang@...>; Xiaoyu Lu
<xiaoyux.lu@...>; Jiang, Guomin <guomin.jiang@...>
Subject: Re: [edk2-devel] [PATCH v3 0/8] CryptoPkg updates for openssl 3.0

Thanks for the contribution.
Merged https://github.com/tianocore/edk2/pull/2766

-----Original Message-----
From: Gerd Hoffmann <kraxel@...>
Sent: Monday, April 11, 2022 7:25 PM
To: devel@edk2.groups.io
Cc: Oliver Steffen <osteffen@...>; Pawel Polawski
<ppolawsk@...>; Wang, Jian J <jian.j.wang@...>; Xiaoyu Lu
<xiaoyux.lu@...>; Yao, Jiewen <jiewen.yao@...>; Jiang,
Guomin <guomin.jiang@...>; Gerd Hoffmann <kraxel@...>
Subject: [PATCH v3 0/8] CryptoPkg updates for openssl 3.0

First batch of patches which update CrtLibSupport so it has everything
needed to build openssl3. Also a testcase update for openssl3.

This does not update the openssl submodule, that'll happen in a
followup patch series.

v3:
- move strcpy() from .h to .c file.
- pick up review tags
v2:
- rebase to latest master.
- add codestyle exception for fcntl.h.

Gerd Hoffmann (8):
CryptoPkg/CrtLibSupport: add fcntl.h
CryptoPkg/CrtLibSupport: add strstr()
CryptoPkg/CrtLibSupport: add INT_MIN
CryptoPkg/CrtLibSupport: add UINT_MAX
CryptoPkg/CrtLibSupport: add MODULESDIR
CryptoPkg/CrtLibSupport: add off_t
CryptoPkg/CrtLibSupport: fix strcpy
CryptoPkg/UnitTest: fix DH testcase

CryptoPkg/Library/Include/CrtLibSupport.h | 12 +++++++++++-
CryptoPkg/Library/Include/fcntl.h | 9 +++++++++
CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 10 ++++++++++
.../Test/UnitTest/Library/BaseCryptLib/DhTests.c | 6 +++---
CryptoPkg/CryptoPkg.ci.yaml | 1 +
5 files changed, 34 insertions(+), 4 deletions(-) create mode 100644
CryptoPkg/Library/Include/fcntl.h

--
2.35.1




Re: Some questions about Azure CI

Michael Kubacki
 

On 4/19/2022 7:43 PM, Michael Kubacki wrote:
The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci I am waiting for permissions to be updated so I can update the actual wiki page and then I'll send a patch for the plugin change with the link to that section.
Regards,
Michael
On 4/19/2022 6:15 PM, Michael Kubacki wrote:
I agree that is ideal but I'm not aware of how to do that at the moment.

Thanks,
Michael

On 4/19/2022 4:52 PM, Michael D Kinney wrote:
Hi Michael,

Can the build log provide a direct link to the log file artifact if an error is detected?

Mike

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Tuesday, April 19, 2022 12:42 PM
To: devel@edk2.groups.io; quic_rcran@...; spbrogan@...; Chao Li <lichao@...>
Subject: Re: [edk2-devel] Some questions about Azure CI

Hi Rebecca,

We are trying to keep the results reporting experience consistent with
other plugins and prevent an overwhelming amount of information being
printed to the build log.

In case other errors are present, providing high-level information from
each plugin can help point the user in the right direction to get more
detail.

I completely understand the concern though, so I'm planning to make
another step toward providing more information about how to debug an
issue, when it occurs. That is to put the step-by-step information about
where to find the file diff into the EDK II Code Formatting wiki page
and then if a failure occurs, print a link to that section of the wiki
page. I am hoping this will provide sufficient information to get to the
file diff at the point of failure.

I should be able to send these patches later today.

Regards,
Michael

On 4/19/2022 12:43 PM, Rebecca Cran wrote:
Since people are going to keep running into this, could we just output
the file diff to the console? That would avoid having to go hunting for
the log file.






Re: Some questions about Azure CI

Michael Kubacki
 

Hi Chao,

Are you referring to the change I made to put the link to the instructions in the build log. Here's an example of what that will look like:

https://github.com/makubacki/tianocore.github.io/blob/temp_show_uncrustify_ci_link_in_build_log/images/edk-ii-code-formatting/temp-example-instruction-link-in-build-log.png?raw=true

(some of the words running together are not in the actual change)

I'm open to moving it elsewhere but developers will need to know how to at least find that or they will have trouble fixing build issues.

Regards,
Michael

On 4/19/2022 9:46 PM, Chao Li wrote:
Hi Micheal,
Using the way your provided the link, I found the detail log, thanks, but this way is not friendly to newbies, because they don't know how to find the tutorial.:)
--
Thanks,
Chao
------------------------
On 4月 20 2022, at 7:43 早上, "Michael Kubacki" <mikuback@...> wrote:
The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci
I am waiting for permissions to be updated so I can update the actual
wiki page and then I'll send a patch for the plugin change with the link
to that section.
Regards,
Michael
On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> I agree that is ideal but I'm not aware of how to do that at the
moment.
>
> Thanks,
> Michael
>
> On 4/19/2022 4:52 PM, Michael D Kinney wrote:
>> Hi Michael,
>>
>> Can the build log provide a direct link to the log file artifact
if an
>> error is detected?
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>>> Michael Kubacki
>>> Sent: Tuesday, April 19, 2022 12:42 PM
>>> To: devel@edk2.groups.io; quic_rcran@...;
>>> spbrogan@...; Chao Li <lichao@...>
>>> Subject: Re: [edk2-devel] Some questions about Azure CI
>>>
>>> Hi Rebecca,
>>>
>>> We are trying to keep the results reporting experience
consistent with
>>> other plugins and prevent an overwhelming amount of information
being
>>> printed to the build log.
>>>
>>> In case other errors are present, providing high-level
information from
>>> each plugin can help point the user in the right direction to
get more
>>> detail.
>>>
>>> I completely understand the concern though, so I'm planning to make
>>> another step toward providing more information about how to
debug an
>>> issue, when it occurs. That is to put the step-by-step
information about
>>> where to find the file diff into the EDK II Code Formatting
wiki page
>>> and then if a failure occurs, print a link to that section of
the wiki
>>> page. I am hoping this will provide sufficient information to
get to the
>>> file diff at the point of failure.
>>>
>>> I should be able to send these patches later today.
>>>
>>> Regards,
>>> Michael
>>>
>>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
>>>> Since people are going to keep running into this, could we
just output
>>>> the file diff to the console? That would avoid having to go
hunting for
>>>> the log file.
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
Sent from Mailspring


Re: [PATCH v4 0/8] Add Variable Flash Info HOB

Michael Kubacki
 

This patch series is still missing reviews from some package maintainers. Please review it when possible.

Thanks,
Michael

On 4/13/2022 10:21 PM, Michael Kubacki wrote:
A friendly reminder to those on the CC line to help review your respective packages in this patch series.
Some of the patches are just minor changes to DSC files and others do not have a significant number of changes.
Thanks,
Michael
On 4/12/2022 12:29 PM, Michael Kubacki wrote:
From: Michael Kubacki <michael.kubacki@...>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479

The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in MdeModulePkg.

For example:
[Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize

These PCDs work as-is in the StandaloneMm driver if they are not
dynamic such as Dynamic or DynamicEx because PCD services are not
readily available in the Standalone MM environment. Platforms that
use Standalone MM today, must define these PCDs as FixedAtBuild in
their platform build. However, the PCDs do allow platforms to treat
the PCDs as Dynamic/DynamicEx and being able to support that is
currently a gap for Standalone MM.

This patch series introduces a HOB that can be produced by the
platform to provide the same information. The HOB list is
available to Standalone MM.

The PCD declarations are left as-is in MdeModulePkg for backward
compatibility. This means unless a platform wants to use the HOB,
their code will continue to work with no change (they do not need
to produce the HOB). Only if the HOB is found, is its value used
instead of the PCDs.

Due to the large number of consumers of this information, access
to the base address and size values is abstracted in a new library
class (as requested in the v1 series) called VariableFlashInfoLib.

The API of VariableFlashInfoLib does not bind the underlying data
structure to the information returned to library users to allow
flexibility in the library implementation in the future.

V4 changes:
1. Add a UINT32 "Reserved" field to VARIABLE_FLASH_INFO.
2. Add a descriptive comment to VariableFlashInfo.h to explain
    HOB usage.

V3 changes:
1. To better clarify usage, renamed the members
    "NvStorageBaseAddress" and "NvStorageLength" in
    "VARIABLE_FLASH_INFO" to "NvVariableBaseAddress" and
    "NvVariableLength".
2. Added description comments to the fields in "VARIABLE_FLASH_INFO".

V2 changes:
1. Abstracted flash info data access with VariableFlashInfoLib.
2. Updated package builds in the repo that build the variable and
    FTW drivers to include VariableFlashInfoLib.
3. Removed a redundant variable assignment in VariableSmm.c.
4. Updated comments in FtwMisc.c and FaultTolerantWritePei.c to
    indicate driver assumption is UINTN (not UINT32)
5. Added a version field to the VARIABLE_FLASH_INFO structure.

Cc: Abner Chang <abner.chang@...>
Cc: Andrew Fish <afish@...>
Cc: Anthony Perard <anthony.perard@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Benjamin You <benjamin.you@...>
Cc: Brijesh Singh <brijesh.singh@...>
Cc: Erdem Aktas <erdemaktas@...>
Cc: Gerd Hoffmann <kraxel@...>
Cc: Guo Dong <guo.dong@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: James Bottomley <jejb@...>
Cc: Jian J Wang <jian.j.wang@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Jordan Justen <jordan.l.justen@...>
Cc: Julien Grall <julien@...>
Cc: Leif Lindholm <quic_llindhol@...>
Cc: Liming Gao <gaoliming@...>
Cc: Maurice Ma <maurice.ma@...>
Cc: Min Xu <min.m.xu@...>
Cc: Nickle Wang <nickle.wang@...>
Cc: Peter Grehan <grehan@...>
Cc: Ray Ni <ray.ni@...>
Cc: Rebecca Cran <rebecca@...>
Cc: Sami Mujawar <sami.mujawar@...>
Cc: Sean Rhodes <sean@...>
Cc: Sebastien Boeuf <sebastien.boeuf@...>
Cc: Tom Lendacky <thomas.lendacky@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>

Michael Kubacki (8):
   MdeModulePkg: Add Variable Flash Info HOB
   MdeModulePkg/VariableFlashInfoLib: Add initial library
   MdeModulePkg/Variable: Consume Variable Flash Info
   MdeModulePkg/FaultTolerantWrite: Consume Variable Flash Info
   ArmVirtPkg/ArmVirt.dsc.inc: Add VariableFlashInfoLib
   EmulatorPkg: Add VariableFlashInfoLib
   OvmfPkg: Add VariableFlashInfoLib
   UefiPayloadPkg: Add VariableFlashInfoLib

MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c | 178 ++++++++++++++++++++
MdeModulePkg/Universal/FaultTolerantWriteDxe/FtwMisc.c |  41 +++--
MdeModulePkg/Universal/FaultTolerantWriteDxe/UpdateWorkingBlock.c |   7 +-
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.c |  28 +--
MdeModulePkg/Universal/Variable/Pei/Variable.c |  14 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableDxe.c |  16 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableNonVolatile.c |  14 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.c |  17 +-
ArmVirtPkg/ArmVirt.dsc.inc |   1 +
EmulatorPkg/EmulatorPkg.dsc |   1 +
MdeModulePkg/Include/Guid/VariableFlashInfo.h | 111 ++++++++++++
MdeModulePkg/Include/Library/VariableFlashInfoLib.h |  68 ++++++++
MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf |  48 ++++++
MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.uni |  12 ++
MdeModulePkg/MdeModulePkg.dec |   8 +
MdeModulePkg/MdeModulePkg.dsc |   2 +
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWrite.h |   7 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf |  10 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmm.inf |  10 +-
MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf |  10 +-
MdeModulePkg/Universal/FaultTolerantWritePei/FaultTolerantWritePei.inf |  10 +-
MdeModulePkg/Universal/Variable/Pei/Variable.h |   2 +
MdeModulePkg/Universal/Variable/Pei/VariablePei.inf |   5 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.h |   7 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf |   5 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf |   5 +-
MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf |   5 +-
OvmfPkg/AmdSev/AmdSevX64.dsc |   1 +
OvmfPkg/Bhyve/BhyveX64.dsc |   1 +
OvmfPkg/CloudHv/CloudHvX64.dsc |   1 +
OvmfPkg/IntelTdx/IntelTdxX64.dsc |   1 +
OvmfPkg/Microvm/MicrovmX64.dsc |   1 +
OvmfPkg/OvmfPkgIa32.dsc |   1 +
OvmfPkg/OvmfPkgIa32X64.dsc |   1 +
OvmfPkg/OvmfPkgX64.dsc |   1 +
OvmfPkg/OvmfXen.dsc |   1 +
UefiPayloadPkg/UefiPayloadPkg.dsc |   1 +
  37 files changed, 558 insertions(+), 94 deletions(-)
  create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.c
  create mode 100644 MdeModulePkg/Include/Guid/VariableFlashInfo.h
  create mode 100644 MdeModulePkg/Include/Library/VariableFlashInfoLib.h
  create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
  create mode 100644 MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.uni


Re: Some questions about Azure CI

Chao Li
 

Hi Micheal,
Using the way your provided the link, I found the detail log, thanks, but this way is not friendly to newbies, because they don't know how to find the tutorial.:)

--
Thanks,
Chao
------------------------


On 4月 20 2022, at 7:43 早上, "Michael Kubacki" <mikuback@...> wrote:
The wiki update is here:
https://github.com/makubacki/tianocore.github.io/blob/add_ci_uncrustify_instructions/EDK-II-Code-Formatting.md#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci

I am waiting for permissions to be updated so I can update the actual
wiki page and then I'll send a patch for the plugin change with the link
to that section.

Regards,
Michael

On 4/19/2022 6:15 PM, Michael Kubacki wrote:
> I agree that is ideal but I'm not aware of how to do that at the moment.
>
> Thanks,
> Michael
>
> On 4/19/2022 4:52 PM, Michael D Kinney wrote:
>> Hi Michael,
>>
>> Can the build log provide a direct link to the log file artifact if an
>> error is detected?
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
>>> Michael Kubacki
>>> Sent: Tuesday, April 19, 2022 12:42 PM
>>> To: devel@edk2.groups.io; quic_rcran@...;
>>> spbrogan@...; Chao Li <lichao@...>
>>> Subject: Re: [edk2-devel] Some questions about Azure CI
>>>
>>> Hi Rebecca,
>>>
>>> We are trying to keep the results reporting experience consistent with
>>> other plugins and prevent an overwhelming amount of information being
>>> printed to the build log.
>>>
>>> In case other errors are present, providing high-level information from
>>> each plugin can help point the user in the right direction to get more
>>> detail.
>>>
>>> I completely understand the concern though, so I'm planning to make
>>> another step toward providing more information about how to debug an
>>> issue, when it occurs. That is to put the step-by-step information about
>>> where to find the file diff into the EDK II Code Formatting wiki page
>>> and then if a failure occurs, print a link to that section of the wiki
>>> page. I am hoping this will provide sufficient information to get to the
>>> file diff at the point of failure.
>>>
>>> I should be able to send these patches later today.
>>>
>>> Regards,
>>> Michael
>>>
>>> On 4/19/2022 12:43 PM, Rebecca Cran wrote:
>>>> Since people are going to keep running into this, could we just output
>>>> the file diff to the console? That would avoid having to go hunting for
>>>> the log file.
>>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>


Sent from Mailspring


[PATCH v1 1/1] .azurepipelines: Add NOOPT to all package builds

Michael Kubacki
 

From: Michael Kubacki <michael.kubacki@...>

The NOOPT build target is used for host-based unit tests. This
change adds the NOOPT target for all packages to ensure that tests
are executed if present.

If the host-based DSC is not specified in the packages CI YAML file,
the host-based compiler plugin will be reported as a skipped test.

Cc: Sean Brogan <sean.brogan@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>
---
.azurepipelines/templates/pr-gate-build-job.yml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipe=
lines/templates/pr-gate-build-job.yml
index 69e4c50afdbb..0e4ad019bf03 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -35,10 +35,10 @@ jobs:
Build.Targets: 'RELEASE,NO-TARGET'
TARGET_NETWORK:
Build.Pkgs: 'NetworkPkg,RedfishPkg'
- Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_OTHER:
Build.Pkgs: 'PcAtChipsetPkg,PrmPkg,ShellPkg,StandaloneMmPkg'
- Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_FMP_FAT_TEST:
Build.Pkgs: 'FmpDevicePkg,FatPkg,UnitTestFrameworkPkg,DynamicTab=
lesPkg'
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
@@ -47,15 +47,15 @@ jobs:
Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_SECURITY:
Build.Pkgs: 'SecurityPkg'
- Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_UEFIPAYLOAD:
Build.Pkgs: 'UefiPayloadPkg'
- Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+ Build.Targets: 'DEBUG,RELEASE,NO-TARGET,NOOPT'
TARGET_PLATFORMS:
# For Platforms only check code. Leave it to Platform CI
# to build them.
Build.Pkgs: 'ArmVirtPkg,EmulatorPkg,OvmfPkg'
- Build.Targets: 'NO-TARGET'
+ Build.Targets: 'NO-TARGET,NOOPT'
=20
workspace:
clean: all
--=20
2.28.0.windows.1


[PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Add Azure DevOps UI debug instructions

Michael Kubacki
 

From: Michael Kubacki <michael.kubacki@...>

Adds a link to the log output that contains instructions on how find
detailed file formatting errors in the Azure DevOps UI.

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Sean Brogan <sean.brogan@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>
---
.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/=
Plugin/UncrustifyCheck/UncrustifyCheck.py
index 22cca0ff1101..00d78864656f 100644
--- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
+++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
@@ -562,6 +562,11 @@ class UncrustifyCheck(ICiBuildPlugin):
self._formatted_file_error_count =3D len(formatted_files)
=20
if self._formatted_file_error_count > 0:
+ logging.error(
+ "Visit the following instructions to learn "
+ "how to find the detailed formatting errors in Azure "
+ "DevOps CI: "
+ "https://github.com/tianocore/tianocore.github.io/wiki/E=
DK-II-Code-Formatting#how-to-find-uncrustify-formatting-errors-in-continu=
ous-integration-ci")
self._tc.LogStdError("Files with formatting errors:\n")
=20
if self._output_file_diffs:
--=20
2.28.0.windows.1


Event: TianoCore Bug Triage - APAC / NAMO - 04/19/2022 #cal-reminder

devel@edk2.groups.io Calendar <noreply@...>
 

Reminder: TianoCore Bug Triage - APAC / NAMO

When:
04/19/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles

Where:
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3a%226e4ce4c4-1242-431b-9a51-92cd01a5df3c%22%7d

Organizer: Liming Gao gaoliming@...

View Event

Description:

TianoCore Bug Triage - APAC / NAMO

Hosted by Liming Gao

 

________________________________________________________________________________

Microsoft Teams meeting

Join on your computer or mobile app

Click here to join the meeting

Join with a video conferencing device

teams@...

Video Conference ID: 116 062 094 0

Alternate VTC dialing instructions

Or call in (audio only)

+1 916-245-6934,,77463821#   United States, Sacramento

Phone Conference ID: 774 638 21#

Find a local number | Reset PIN

Learn More | Meeting options


Re: [edk2-platforms][IMPORTANT] CI in edk2-platforms

Pedro Falcato
 

Hi Michael,

I'm in the exact same situation as Ard. My timezone + my lack of availability (I do this as one of my hobbies, and not as a job) make it very hard to attend meetings,
although I really don't mind discussing these issues on the mailing list.

I do have something to say about point 2) though. My package (Ext4Pkg) only has a single maintainer (myself) and it's really bothersome to try and merge my own patches as I need to bother
the EDK2 platforms stewards every time I want to do so. If someone could step up to be a co-maintainer and help review my own patches from time to time, it would be really great.

Best regards,
Pedro


On Tue, Apr 19, 2022 at 4:17 PM Michael Kubacki <mikuback@...> wrote:
Hello edk2-platforms maintainers,

There is a TianoCore community meeting on Tools and CI that takes place
weekly on Mondays from 19:30 - 20:30 PDT.

Meeting Details:
   https://github.com/tianocore/edk2/discussions/2614

Several recurring topics have come up regarding edk2-platforms:

   1. Consistently define toolchain support in edk2-platforms
   https://bugzilla.tianocore.org/show_bug.cgi?id=3660

   2. Audit edk2-platforms maintainers
   https://bugzilla.tianocore.org/show_bug.cgi?id=3659

   3. Enable continuous integration (CI) in edk2-platforms
   https://bugzilla.tianocore.org/show_bug.cgi?id=3658

   4. Stable tag support in edk2-platforms
   https://bugzilla.tianocore.org/show_bug.cgi?id=3661

As a maintainer, your help is needed to make progress on these items.

Ultimately, we want the open-source platforms to be more approachable
and reliable by removing inactive platforms, eliminating unnecessary
tool divergence, enabling well-defined and functional CI builds, and
refreshing the maintainer list with the appropriate contacts.

To start, can you please respond if a representative from your package
is able to attend the meeting at the regularly scheduled time to discuss
these topics?

If not, can you please state the representative and their timezone you
would like to join the discussion and we can try to plan around that.

We would like to add this to May 2, 2022 meeting instance agenda if we
have quorum.

Thank you for your time and assistance.

Regards,
Michael


--
Pedro Falcato


Re: [PATCH 0/3] ArmPlatformPkg: Fix Scripts/Ds5 debugging and Makefile

Rebecca Cran
 

Could I get some reviews on this please?


--

Rebecca Cran

On 4/10/22 19:16, Rebecca Cran wrote:
I ran into some problems debugging EDK2 code using Development Studio with
the files under ArmPlatformPkg/Scripts and these patches fix them.

I'm using Arm Development Studio 2021.2 and not DS-5, so I'm not sure if
these changes would break things for people using the older environment.

Rebecca Cran (3):
ArmPlatformPkg: Fix error message in Scripts/Ds5/edk2_debugger.py
ArmPlatformPkg: Fix target initialisation in cmd_load_symbols.py
ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile

ArmPlatformPkg/Scripts/Ds5/cmd_load_symbols.py | 5 ++---
ArmPlatformPkg/Scripts/Ds5/edk2_debugger.py | 2 +-
ArmPlatformPkg/Scripts/Makefile | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)


Re: [PATCH 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

Rebecca Cran
 

Could I get some reviews on this please?

--
Rebecca Cran

On 4/13/22 16:45, Rebecca Cran wrote:
Copy code from PrePi to PrePeiCore that prints the firmware version
and build date early in the boot process.

Signed-off-by: Rebecca Cran <quic_rcran@...>
---
ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 17 +++++++++++++++++
ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 3 +++
ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 3 +++
3 files changed, 23 insertions(+)

diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
index 6dd9bcdea24f..9e2a0db676b9 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c
@@ -11,6 +11,8 @@
#include <Library/CacheMaintenanceLib.h>
#include <Library/DebugAgentLib.h>
#include <Library/ArmLib.h>
+#include <Library/PrintLib.h>
+#include <Library/SerialPortLib.h>
#include "PrePeiCore.h"
@@ -58,6 +60,9 @@ CEntryPoint (
IN EFI_PEI_CORE_ENTRY_POINT PeiCoreEntryPoint
)
{
+ CHAR8 Buffer[100];
+ UINTN CharCount;
+
// Data Cache enabled on Primary core when MMU is enabled.
ArmDisableDataCache ();
// Invalidate instruction cache
@@ -90,6 +95,18 @@ CEntryPoint (
// If not primary Jump to Secondary Main
if (ArmPlatformIsPrimaryCore (MpId)) {
+ // Initialize the Serial Port
+ SerialPortInitialize ();
+ CharCount = AsciiSPrint (
+ Buffer,
+ sizeof (Buffer),
+ "UEFI firmware (version %s built at %a on %a)\n\r",
+ (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString),
+ __TIME__,
+ __DATE__
+ );
+ SerialPortWrite ((UINT8 *)Buffer, CharCount);
+
// Initialize the Debug Agent for Source Level Debugging
InitializeDebugAgent (DEBUG_AGENT_INIT_POSTMEM_SEC, NULL, NULL);
SaveAndSetDebugTimerInterrupt (TRUE);
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
index fb01dd1a113e..83029cf08d1a 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf
@@ -57,6 +57,9 @@
gEfiTemporaryRamSupportPpiGuid
gArmMpCoreInfoPpiGuid
+[Pcd]
+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
+
[FeaturePcd]
gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores
diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
index e9eb092d3ac9..9f9ad81586ed 100644
--- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
+++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf
@@ -55,6 +55,9 @@
[Ppis]
gEfiTemporaryRamSupportPpiGuid
+[Pcd]
+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString
+
[FeaturePcd]
gArmPlatformTokenSpaceGuid.PcdSendSgiToBringUpSecondaryCores

7521 - 7540 of 96543