Date   

[PATCH v2 071/105] .mailmap: Add an entry for Qing Huang

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Qing Huang to have his name and email address
displayed properly in the git history.

Cc: Qing Huang <qing.huang@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Qing Huang doesn't give his
approval, by replying to this patch with:
Reviewed-by: Qing Huang <qing.huang@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Qing Huang <qing.huang@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 2 ++
1 file changed, 2 insertions(+)

diff --git a/.mailmap b/.mailmap
index b770ab89d538..ff06a31965ac 100644
--- a/.mailmap
+++ b/.mailmap
@@ -136,3 +136,5 @@ Philippe Mathieu-Daudé <philmd@...>
Qian Ouyang <qian.ouyang@...>
Qian Ouyang <qian.ouyang@...> <qianouyang@6f19259b-4bc3-4df7-8a09-765794883524>
Qian Ouyang <qian.ouyang@...> <qouyang@6f19259b-4bc3-4df7-8a09-765794883524>
+Qing Huang <qing.huang@...>
+Qing Huang <qing.huang@...> <qhuang8@6f19259b-4bc3-4df7-8a09-765794883524>
--
2.21.0


[PATCH v2 070/105] .mailmap: Add an entry for Qian Ouyang

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Qian Ouyang to have his name and email address
displayed properly in the git history.

Cc: Qian Ouyang <qian.ouyang@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Qian Ouyang doesn't give his
approval, by replying to this patch with:
Reviewed-by: Qian Ouyang <qian.ouyang@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Qian Ouyang <qian.ouyang@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 3 +++
1 file changed, 3 insertions(+)

diff --git a/.mailmap b/.mailmap
index fe2136ad5a95..b770ab89d538 100644
--- a/.mailmap
+++ b/.mailmap
@@ -133,3 +133,6 @@ Olivier Martin <olivier.martin@...> <Olivier Martin olivier.martin@...>
Pedroa Liu <pedroa.liu@...>
Penny Gao <pgao2@...> <pgao2@6f19259b-4bc3-4df7-8a09-765794883524>
Philippe Mathieu-Daudé <philmd@...>
+Qian Ouyang <qian.ouyang@...>
+Qian Ouyang <qian.ouyang@...> <qianouyang@6f19259b-4bc3-4df7-8a09-765794883524>
+Qian Ouyang <qian.ouyang@...> <qouyang@6f19259b-4bc3-4df7-8a09-765794883524>
--
2.21.0


[PATCH v2 068/105] .mailmap: Add an entry for Penny Gao

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Penny Gao to have his name and email address
displayed properly in the git history.

Cc: Penny Gao <pgao2@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Penny Gao doesn't give his
approval, by replying to this patch with:
Reviewed-by: Penny Gao <pgao2@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Penny Gao <pgao2@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index d3994f41cc0f..249df5961cf5 100644
--- a/.mailmap
+++ b/.mailmap
@@ -131,3 +131,4 @@ Olivier Martin <olivier.martin@...> <Olivier.Martin@...>
Olivier Martin <olivier.martin@...> <oliviermartin@Edk2>
Olivier Martin <olivier.martin@...> <Olivier Martin olivier.martin@...>
Pedroa Liu <pedroa.liu@...>
+Penny Gao <pgao2@...> <pgao2@6f19259b-4bc3-4df7-8a09-765794883524>
--
2.21.0


[PATCH v2 069/105] .mailmap: Add an entry for Philippe Mathieu-Daudé

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Philippe Mathieu-Daudé to have his name and email address
displayed properly in the git history.

Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 249df5961cf5..fe2136ad5a95 100644
--- a/.mailmap
+++ b/.mailmap
@@ -132,3 +132,4 @@ Olivier Martin <olivier.martin@...> <oliviermartin@Edk2>
Olivier Martin <olivier.martin@...> <Olivier Martin olivier.martin@...>
Pedroa Liu <pedroa.liu@...>
Penny Gao <pgao2@...> <pgao2@6f19259b-4bc3-4df7-8a09-765794883524>
+Philippe Mathieu-Daudé <philmd@...>
--
2.21.0


[PATCH v2 067/105] .mailmap: Add an entry for Pedroa Liu

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Pedroa Liu to have his name and email address
displayed properly in the git history.

Cc: Pedroa Liu <pedroa.liu@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Pedroa Liu doesn't give his
approval, by replying to this patch with:
Reviewed-by: Pedroa Liu <pedroa.liu@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Pedroa Liu <pedroa.liu@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 496eaeb47625..d3994f41cc0f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -130,3 +130,4 @@ Olivier Martin <olivier.martin@...> <oliviermartin@6f19259b-4bc3-4df7-8a09-7
Olivier Martin <olivier.martin@...> <Olivier.Martin@...>
Olivier Martin <olivier.martin@...> <oliviermartin@Edk2>
Olivier Martin <olivier.martin@...> <Olivier Martin olivier.martin@...>
+Pedroa Liu <pedroa.liu@...>
--
2.21.0


[PATCH v2 066/105] .mailmap: Add an entry for Olivier Martin

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Olivier Martin to have his name and email address
displayed properly in the git history.

Cc: Olivier Martin <olivier.martin@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Olivier Martin doesn't give his
approval, by replying to this patch with:
Reviewed-by: Olivier Martin <olivier.martin@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Olivier Martin <olivier.martin@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/.mailmap b/.mailmap
index a3074feb017c..496eaeb47625 100644
--- a/.mailmap
+++ b/.mailmap
@@ -125,3 +125,8 @@ Michael Zimmermann <sigmaepsilon92@...> <[mailto:sigmaepsilon92@...]
Mike Wu <mike.wu@...> <mikewuping@6f19259b-4bc3-4df7-8a09-765794883524>
Ming Tan <ming.tan@...>
Nikolai Saoukh <nms@...>
+Olivier Martin <olivier.martin@...> <oliviermartin>
+Olivier Martin <olivier.martin@...> <oliviermartin@6f19259b-4bc3-4df7-8a09-765794883524>
+Olivier Martin <olivier.martin@...> <Olivier.Martin@...>
+Olivier Martin <olivier.martin@...> <oliviermartin@Edk2>
+Olivier Martin <olivier.martin@...> <Olivier Martin olivier.martin@...>
--
2.21.0


Re: [PATCH v2 001/105] .mailmap: Add a stub with documentation

Laszlo Ersek
 

On 12/06/19 12:24, Philippe Mathieu-Daudé wrote:
The .mailmap git feature helps fixing commit mistakes (in name/email).

The easiest way to use it is with the --use-mailmap flag:

$ git log --use-mailmap

See:
* https://git-scm.com/docs/git-shortlog#_mapping_authors
* https://git-scm.com/docs/git-check-mailmap#_mapping_authors

Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
.mailmap | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 .mailmap

diff --git a/.mailmap b/.mailmap
new file mode 100644
index 000000000000..6d88189a58d4
--- /dev/null
+++ b/.mailmap
@@ -0,0 +1,11 @@
+#
+# This list is used by git-shortlog to fix a few botched name translations
+# in the git archive, either because the author's full name was messed up
+# and/or not always written the same way, making contributions from the
+# same person appearing not to be so or badly displayed.
+#
+# Please keep this file sorted alphabetically, and email in lowercase.
+# The format used is:
+#
+# Firstname Lastname <email@...>
+#
Assuming this new text file uses CRLF line terminators (for consistency
with the rest of the project at this time):

Reviewed-by: Laszlo Ersek <lersek@...>

Thanks!
Laszlo


Re: [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

Laszlo Ersek
 

On 12/06/19 12:24, Philippe Mathieu-Daude wrote:
The .mailmap git feature helps fixing commit mistakes (in name/email).

The easiest way to use it is with the --use-mailmap flag:

$ git log --use-mailmap

See documentation [1] and [2], and interesting blog [3].

Laszlo replied [4] to v1 explaining stewards want to avoid avoid
cross-domain mapping, and suggested to split in per email-address
patches, so contributors can individually Ack/Nack.
Similarly, stewards can Nack if there is a cross-domain issue, since
these are not obvious to me (they would happen if someone was working
for a company at the time the repository was using SVN, the switched
company and contributed later at the time the repository was passed
to GIT).
I suggest the following:

- Collect feedback (from individual reviewers / contributors) for one or
two weeks

- Accept cross-domain mappings in any patch where the person subject to
the patch is ACKing the patch from the mapped-to (i.e. "current") email
address. This is now a *lot* easier to do, because the patch series is
structured by person.

- After one or two weeks, push all the patches that have been approved
like explained above.

- Repost the rest of the series, CC'd solely to the stewards. We will
then have to go through the backlog, and decide one by one whether, for
person X, the proposed mappings are cross-domain or not, and ACK or NACK
accordingly.

- Push the second round, drop the rest for good.

So in this first review iteration, we really depend on people to respond
from their "new" (mapped-to) addresses.

Fantastic job on the split-per-person!

Thanks!
Laszlo



Since I can not Cc all the recipients in this cover (107, MTA restricts
to 100), I'm documenting all patches individually.

- Another note regarding groups.io 40 posts per 30min limit -

My previous big series [5] involved 79 patches, and groups.io banned
me for some time after the 40th post. On [5] Laszlo suggested to test
the following git-send-email options to see if we can work with big
series and groups.io:

--batch-size=<num>
Some email servers (e.g. smtp.163.com) limit the number
emails to be sent per session (connection) and this will
lead to a failure when sending many messages. With this
option, send-email will disconnect after sending $<num>
messages and wait for a few seconds (see --relogin-delay)
and reconnect, to work around such a limit. You may want
to use some form of credential helper to avoid having to
retype your password every time this happens. Defaults to
the sendemail.smtpBatchSize configuration variable.

--relogin-delay=<int>
Waiting $<int> seconds before reconnecting to SMTP server.
Used together with --batch-size option. Defaults to the
sendemail.smtpReloginDelay configuration variable.

So I'm sending this series using git-publish [7] after setting the
following values:

$ git config sendemail.smtpBatchSize 33
$ git config sendemail.smtpReloginDelay 1848

Regards,

Phil.

[1] https://git-scm.com/docs/git-shortlog#_mapping_authors
[2] https://git-scm.com/docs/git-check-mailmap#_mapping_authors
[3] https://github.com/sympy/sympy/wiki/Using-.mailmap#making-mailmap-entries
[4] https://edk2.groups.io/g/devel/message/51657
[5] https://edk2.groups.io/g/devel/message/51606
[6] https://edk2.groups.io/g/devel/message/51761
[7] https://github.com/stefanha/git-publish

Cc: Andrew Fish <afish@...>
Cc: Laszlo Ersek <lersek@...>
Cc: Leif Lindholm <leif.lindholm@...>
Cc: Michael D Kinney <michael.d.kinney@...>


Philippe Mathieu-Daudé (105):
.mailmap: Add a stub with documentation
.mailmap: Add an entry for Alexei Fedorov
.mailmap: Add an entry for Amy Chan
.mailmap: Add an entry for Andrew Fish
.mailmap: Add an entry for Antoine Cœur
.mailmap: Add an entry for Ard Biesheuvel
.mailmap: Add an entry for Ashley DeSimone
.mailmap: Add an entry for Ashraf Javeed
.mailmap: Add an entry for Baraneedharan Anbazhagan
.mailmap: Add an entry for Bob Feng
.mailmap: Add an entry for Brendan Jackman
.mailmap: Add an entry for Chao Zhang
.mailmap: Add an entry for Chasel Chiu
.mailmap: Add an entry for Chen A Chen
.mailmap: Add an entry for Cheng Ching Jen
.mailmap: Add an entry for Christian Rodriguez
.mailmap: Add an entry for Christopher J Zurcher
.mailmap: Add an entry for Dandan Bi
.mailmap: Add an entry for David Chan
.mailmap: Add an entry for David Wei
.mailmap: Add an entry for Derek Lin
.mailmap: Add an entry for Digant H Solanki
.mailmap: Add an entry for Eric Dong
.mailmap: Add an entry for Eric Jin
.mailmap: Add an entry for Erik Bjorge
.mailmap: Add an entry for Eugene Cohen
.mailmap: Add an entry for Feng Tian
.mailmap: Add an entry for Feng Yunhua
.mailmap: Add an entry for Guo Dong
.mailmap: Add an entry for Hao Wu
.mailmap: Add an entry for Harry Liebel
.mailmap: Add an entry for Herbie Robinson
.mailmap: Add an entry for Hess Chen
.mailmap: Add an entry for Hot Tian
.mailmap: Add an entry for Jaben Carsey
.mailmap: Add an entry for Jan Dabros
.mailmap: Add an entry for Jeff Bobzin
.mailmap: Add an entry for Jian J Wang
.mailmap: Add an entry for Jiaxin Wu
.mailmap: Add an entry for Jim Dailey
.mailmap: Add an entry for Jordan Justen
.mailmap: Add an entry for Ken Lu
.mailmap: Add an entry for Laszlo Ersek
.mailmap: Add an entry for Laurie Jarlstrom
.mailmap: Add an entry for Lee Rosenbaum
.mailmap: Add an entry for Leon Li
.mailmap: Add an entry for Liming Gao
.mailmap: Add an entry for Loh Tien Hock
.mailmap: Add an entry for Lubo Zhang
.mailmap: Add an entry for Lu Shifei
.mailmap: Add an entry for Maciej Rabeda
.mailmap: Add an entry for Maggie Chu
.mailmap: Add an entry for Marc-André Lureau
.mailmap: Add an entry for Marc W Chen
.mailmap: Add an entry for Marvin Häuser
.mailmap: Add an entry for Mateusz Albecki
.mailmap: Add an entry for Maurice Ma
.mailmap: Add an entry for Maxim Shvecov
.mailmap: Add an entry for Michael Johnson
.mailmap: Add an entry for Michael Kinney
.mailmap: Add an entry for Michael Kubacki
.mailmap: Add an entry for Michael Zimmermann
.mailmap: Add an entry for Mike Wu
.mailmap: Add an entry for Ming Tan
.mailmap: Add an entry for Nikolai Saoukh
.mailmap: Add an entry for Olivier Martin
.mailmap: Add an entry for Pedroa Liu
.mailmap: Add an entry for Penny Gao
.mailmap: Add an entry for Philippe Mathieu-Daudé
.mailmap: Add an entry for Qian Ouyang
.mailmap: Add an entry for Qing Huang
.mailmap: Add an entry for Qiu Shumin
.mailmap: Add an entry for Ray Ni
.mailmap: Add an entry for Rebecca Cran
.mailmap: Add an entry for Richard Thomaiyar
.mailmap: Add an entry for Rodrigo Gonzalez del Cueto
.mailmap: Add an entry for Ronald Cron
.mailmap: Add an entry for Rui Sun
.mailmap: Add an entry for Sachin Agrawal
.mailmap: Add an entry for Samer El-Haj-Mahmoud
.mailmap: Add an entry for Satya Yarlagadda
.mailmap: Add an entry for Sergey Isakov
.mailmap: Add an entry for Shenglei Zhang
.mailmap: Add an entry for Siyuan Fu
.mailmap: Add an entry for Songpeng Li
.mailmap: Add an entry for Sriram Subramanian
.mailmap: Add an entry for Star Zeng
.mailmap: Add an entry for Steven Shi
.mailmap: Add an entry for Ting Ye
.mailmap: Add an entry for Tomas Pilar
.mailmap: Add an entry for Vanguput Narendra
.mailmap: Add an entry for Vitaly Cheptsov
.mailmap: Add an entry for Vladimir Olovyannikov
.mailmap: Add an entry for Wang Fan
.mailmap: Add an entry for Wang Yu
.mailmap: Add an entry for Wei Xu
.mailmap: Add an entry for Xiaofeng Wang
.mailmap: Add an entry for Xiaoyu Lu
.mailmap: Add an entry for Xue Shengfeng
.mailmap: Add an entry for Yao Jiewen
.mailmap: Add an entry for Yeh Greg
.mailmap: Add an entry for Yingke Liu
.mailmap: Add an entry for Yonghong Zhu
.mailmap: Add an entry for Yu-Chen Lin
.mailmap: Add an entry for Zailiang Sun

.mailmap | 200 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 200 insertions(+)
create mode 100644 .mailmap


Re: [PATCH edk2-platforms 1/2] Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC

Laszlo Ersek
 

On 12/06/19 12:02, Ard Biesheuvel wrote:
Generally, variables should only have external linkage if needed,
so make mAcpiRegistration STATIC, given that static linkage suffices
for it.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...>
---
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
index ea7591d70443..c0ad7ced2959 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
@@ -64,7 +64,7 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = {
}
};

-EFI_EVENT mAcpiRegistration = NULL;
+STATIC EFI_EVENT mAcpiRegistration = NULL;

/**
This function reads PCI ID of the controller.
The patch does what it says on the tin, so:

Reviewed-by: Laszlo Ersek <lersek@...>

But, this too should have type "VOID *"; so if you have capacity for an
extra patch (or an extra change in this same patch), I'd recommend
fixing up the type.

Related commits (from edk2):

- 10eec5aa9297 ("MdeModulePkg: stop abusing EFI_EVENT for protocol
notify registration", 2019-10-09)

- fcf8bdcd5313 ("SecurityPkg: stop abusing EFI_EVENT for protocol notify
registration", 2019-10-09)

Thanks!
Laszlo


Re: [PATCH edk2-platforms 2/2] Platform/ARM/ArmJunoDxe: use PciIo protocol notify to program the MAC

Ard Biesheuvel
 

On Fri, 6 Dec 2019 at 12:12, Laszlo Ersek <lersek@...> wrote:

On 12/06/19 12:02, Ard Biesheuvel wrote:
Instead of connecting and thus enumerating the PCIe topology in a
platform driver, just so that we can grab the PciIo protocol that
belongs to the Marvell Yukon NIC and program its MAC address, rely
on a protocol notification handler to do this whenever the core code
decides to enumerate the PCIe.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...>
---
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 161 ++++----------------
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
2 files changed, 30 insertions(+), 132 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
index c0ad7ced2959..ebaf2aa134da 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
@@ -32,39 +32,8 @@
STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } };
#endif

-typedef struct {
- ACPI_HID_DEVICE_PATH AcpiDevicePath;
- PCI_DEVICE_PATH PciDevicePath;
- EFI_DEVICE_PATH_PROTOCOL EndDevicePath;
-} EFI_PCI_ROOT_BRIDGE_DEVICE_PATH;
-
-STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = {
- {
- { ACPI_DEVICE_PATH,
- ACPI_DP,
- { (UINT8) (sizeof (ACPI_HID_DEVICE_PATH)),
- (UINT8) ((sizeof (ACPI_HID_DEVICE_PATH)) >> 8) }
- },
- EISA_PNP_ID (0x0A03),
- 0
- },
- {
- { HARDWARE_DEVICE_PATH,
- HW_PCI_DP,
- { (UINT8) (sizeof (PCI_DEVICE_PATH)),
- (UINT8) ((sizeof (PCI_DEVICE_PATH)) >> 8) }
- },
- 0,
- 0
- },
- {
- END_DEVICE_PATH_TYPE,
- END_ENTIRE_DEVICE_PATH_SUBTYPE,
- { END_DEVICE_PATH_LENGTH, 0 }
- }
-};
-
STATIC EFI_EVENT mAcpiRegistration = NULL;
+STATIC EFI_EVENT mPciIoNotificationRegistration = NULL;
(1) Please use "VOID *" as the type of "mPciIoNotificationRegistration".

EFI_EVENT happens to work (because it is, regrettably, a typedef, per
spec, to "VOID *").

But semantically we need "VOID *" here -- please see the "Registration"
parameter of EFI_BOOT_SERVICES.RegisterProtocolNotify() and
EFI_BOOT_SERVICES.LocateProtocol().
OK, thanks for spotting that.


/**
This function reads PCI ID of the controller.
@@ -99,59 +68,6 @@ ReadMarvellYoukonPciId (
return EFI_SUCCESS;
}

-/**
- This function searches for Marvell Yukon NIC on the Juno
- platform and returns PCI IO protocol handle for the controller.
-
- @param[out] PciIo PCI IO protocol handle
-**/
-STATIC
-EFI_STATUS
-GetMarvellYukonPciIoProtocol (
- OUT EFI_PCI_IO_PROTOCOL **PciIo
- )
-{
- UINTN HandleCount;
- EFI_HANDLE *HandleBuffer;
- UINTN HIndex;
- EFI_STATUS Status;
-
- Status = gBS->LocateHandleBuffer (
- ByProtocol,
- &gEfiPciIoProtocolGuid,
- NULL,
- &HandleCount,
- &HandleBuffer);
- if (EFI_ERROR (Status)) {
- return (Status);
- }
-
- for (HIndex = 0; HIndex < HandleCount; ++HIndex) {
- // If PciIo opened with EFI_OPEN_PROTOCOL_GET_PROTOCOL, the CloseProtocol() is not required
- Status = gBS->OpenProtocol (
- HandleBuffer[HIndex],
- &gEfiPciIoProtocolGuid,
- (VOID **) PciIo,
- NULL,
- NULL,
- EFI_OPEN_PROTOCOL_GET_PROTOCOL);
- if (EFI_ERROR (Status)) {
- continue;
- }
-
- Status = ReadMarvellYoukonPciId (*PciIo, JUNO_MARVELL_YUKON_ID);
- if (EFI_ERROR (Status)) {
- continue;
- } else {
- break;
- }
- }
-
- gBS->FreePool (HandleBuffer);
-
- return Status;
-}
-
/**
This function restore the original controller attributes

@@ -326,18 +242,14 @@ WriteMacAddress (
**/
STATIC
EFI_STATUS
-ArmJunoSetNicMacAddress ()
+ArmJunoSetNicMacAddress (
+ IN EFI_PCI_IO_PROTOCOL *PciIo
+ )
{
UINT64 OldPciAttr;
- EFI_PCI_IO_PROTOCOL* PciIo;
UINT32 PciRegBase;
EFI_STATUS Status;

- Status = GetMarvellYukonPciIoProtocol (&PciIo);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
PciRegBase = 0;
Status = InitPciDev (PciIo, &PciRegBase, &OldPciAttr);
if (EFI_ERROR (Status)) {
@@ -352,14 +264,8 @@ ArmJunoSetNicMacAddress ()
}

/**
- Notification function of the event defined as belonging to the
- EFI_END_OF_DXE_EVENT_GROUP_GUID event group that was created in
- the entry point of the driver.
-
- This function is called when an event belonging to the
- EFI_END_OF_DXE_EVENT_GROUP_GUID event group is signalled. Such an
- event is signalled once at the end of the dispatching of all
- drivers (end of the so called DXE phase).
+ This function is called when a gEfiPciIoProtocolGuid protocol instance is
+ registered in the protocol database.

@param[in] Event Event declared in the entry point of the driver whose
notification function is being invoked.
@@ -367,33 +273,30 @@ ArmJunoSetNicMacAddress ()
**/
STATIC
VOID
-OnEndOfDxe (
+PciIoNotificationEvent (
IN EFI_EVENT Event,
IN VOID *Context
)
{
- EFI_DEVICE_PATH_PROTOCOL* PciRootComplexDevicePath;
- EFI_HANDLE Handle;
- EFI_STATUS Status;
+ EFI_STATUS Status;
+ EFI_PCI_IO_PROTOCOL *PciIo;

- //
- // PCI Root Complex initialization
- // At the end of the DXE phase, we should get all the driver dispatched.
- // Force the PCI Root Complex to be initialized. It allows the OS to skip
- // this step.
- //
- PciRootComplexDevicePath = (EFI_DEVICE_PATH_PROTOCOL*) &mPciRootComplexDevicePath;
- Status = gBS->LocateDevicePath (&gEfiPciRootBridgeIoProtocolGuid,
- &PciRootComplexDevicePath,
- &Handle);
+ Status = gBS->LocateProtocol (&gEfiPciIoProtocolGuid,
+ mPciIoNotificationRegistration, (VOID **)&PciIo);
+ if (EFI_ERROR (Status)) {
+ return;
+ }

- Status = gBS->ConnectController (Handle, NULL, PciRootComplexDevicePath, FALSE);
- ASSERT_EFI_ERROR (Status);
+ Status = ReadMarvellYoukonPciId (PciIo, JUNO_MARVELL_YUKON_ID);
+ if (EFI_ERROR (Status)) {
+ return;
+ }

- Status = ArmJunoSetNicMacAddress ();
+ Status = ArmJunoSetNicMacAddress (PciIo);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "ArmJunoDxe: Failed to set Marvell Yukon NIC MAC address\n"));
}
+ gBS->CloseEvent (Event);
}

EFI_STATUS
@@ -408,7 +311,6 @@ ArmJunoEntryPoint (
CHAR16 *TextDevicePath;
UINTN TextDevicePathSize;
UINT32 JunoRevision;
- EFI_EVENT EndOfDxeEvent;

//
// Register the OHCI and EHCI controllers as non-coherent
@@ -497,20 +399,17 @@ ArmJunoEntryPoint (
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);

//
- // Create an event belonging to the "gEfiEndOfDxeEventGroupGuid" group.
- // The "OnEndOfDxe()" function is declared as the call back function.
- // It will be called at the end of the DXE phase when an event of the
- // same group is signalled to inform about the end of the DXE phase.
- // Install the INSTALL_FDT_PROTOCOL protocol.
+ // Create a protocol notification event handler on the PciIo protocol
+ // so we can set the MAC address on the Marvell Yukon as soon as it
+ // appears.
//
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
- TPL_CALLBACK,
- OnEndOfDxe,
- NULL,
- &gEfiEndOfDxeEventGroupGuid,
- &EndOfDxeEvent
- );
+ EfiCreateProtocolNotifyEvent (
+ &gEfiPciIoProtocolGuid,
+ TPL_NOTIFY,
(2) I generally prefer the lowest TPL that works, so I'd suggest
TPL_CALLBACK here.
I'd prefer to keep this as TPL_NOTIFY, given that we are attaching to
a PCI device, enabling it, poking some values into a BAR window and
disabling it again.

With (1) updated, and (2) optionally updated (if you agree):

Reviewed-by: Laszlo Ersek <lersek@...>
Thanks,


+ PciIoNotificationEvent,
+ NULL,
+ &mPciIoNotificationRegistration
+ );

#ifndef DYNAMIC_TABLES_FRAMEWORK
// Declare the related ACPI Tables
diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
index 7c118d9c9c6b..d016967c3c37 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
@@ -44,7 +44,6 @@ [LibraryClasses]
UefiDriverEntryPoint

[Guids]
- gEfiEndOfDxeEventGroupGuid
gEfiFileInfoGuid

[Protocols]


Re: [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

Philippe Mathieu-Daudé <philmd@...>
 

On 12/6/19 12:24 PM, Philippe Mathieu-Daude wrote:
[...]
- Another note regarding groups.io 40 posts per 30min limit -
My previous big series [5] involved 79 patches, and groups.io banned
me for some time after the 40th post. On [5] Laszlo suggested to test
the following git-send-email options to see if we can work with big
series and groups.io:
--batch-size=<num>
Some email servers (e.g. smtp.163.com) limit the number
emails to be sent per session (connection) and this will
lead to a failure when sending many messages. With this
option, send-email will disconnect after sending $<num>
messages and wait for a few seconds (see --relogin-delay)
and reconnect, to work around such a limit. You may want
to use some form of credential helper to avoid having to
retype your password every time this happens. Defaults to
the sendemail.smtpBatchSize configuration variable.
--relogin-delay=<int>
Waiting $<int> seconds before reconnecting to SMTP server.
Used together with --batch-size option. Defaults to the
sendemail.smtpReloginDelay configuration variable.
So I'm sending this series using git-publish [7] after setting the
following values:
$ git config sendemail.smtpBatchSize 33
$ git config sendemail.smtpReloginDelay 1848
Replying to self after 66 in an hour to verify that I'm not banned ... :)


Re: [PATCH edk2-platforms 2/2] Platform/ARM/ArmJunoDxe: use PciIo protocol notify to program the MAC

Laszlo Ersek
 

On 12/06/19 12:02, Ard Biesheuvel wrote:
Instead of connecting and thus enumerating the PCIe topology in a
platform driver, just so that we can grab the PciIo protocol that
belongs to the Marvell Yukon NIC and program its MAC address, rely
on a protocol notification handler to do this whenever the core code
decides to enumerate the PCIe.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...>
---
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 161 ++++----------------
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf | 1 -
2 files changed, 30 insertions(+), 132 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
index c0ad7ced2959..ebaf2aa134da 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
@@ -32,39 +32,8 @@
STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } };
#endif

-typedef struct {
- ACPI_HID_DEVICE_PATH AcpiDevicePath;
- PCI_DEVICE_PATH PciDevicePath;
- EFI_DEVICE_PATH_PROTOCOL EndDevicePath;
-} EFI_PCI_ROOT_BRIDGE_DEVICE_PATH;
-
-STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = {
- {
- { ACPI_DEVICE_PATH,
- ACPI_DP,
- { (UINT8) (sizeof (ACPI_HID_DEVICE_PATH)),
- (UINT8) ((sizeof (ACPI_HID_DEVICE_PATH)) >> 8) }
- },
- EISA_PNP_ID (0x0A03),
- 0
- },
- {
- { HARDWARE_DEVICE_PATH,
- HW_PCI_DP,
- { (UINT8) (sizeof (PCI_DEVICE_PATH)),
- (UINT8) ((sizeof (PCI_DEVICE_PATH)) >> 8) }
- },
- 0,
- 0
- },
- {
- END_DEVICE_PATH_TYPE,
- END_ENTIRE_DEVICE_PATH_SUBTYPE,
- { END_DEVICE_PATH_LENGTH, 0 }
- }
-};
-
STATIC EFI_EVENT mAcpiRegistration = NULL;
+STATIC EFI_EVENT mPciIoNotificationRegistration = NULL;
(1) Please use "VOID *" as the type of "mPciIoNotificationRegistration".

EFI_EVENT happens to work (because it is, regrettably, a typedef, per
spec, to "VOID *").

But semantically we need "VOID *" here -- please see the "Registration"
parameter of EFI_BOOT_SERVICES.RegisterProtocolNotify() and
EFI_BOOT_SERVICES.LocateProtocol().


/**
This function reads PCI ID of the controller.
@@ -99,59 +68,6 @@ ReadMarvellYoukonPciId (
return EFI_SUCCESS;
}

-/**
- This function searches for Marvell Yukon NIC on the Juno
- platform and returns PCI IO protocol handle for the controller.
-
- @param[out] PciIo PCI IO protocol handle
-**/
-STATIC
-EFI_STATUS
-GetMarvellYukonPciIoProtocol (
- OUT EFI_PCI_IO_PROTOCOL **PciIo
- )
-{
- UINTN HandleCount;
- EFI_HANDLE *HandleBuffer;
- UINTN HIndex;
- EFI_STATUS Status;
-
- Status = gBS->LocateHandleBuffer (
- ByProtocol,
- &gEfiPciIoProtocolGuid,
- NULL,
- &HandleCount,
- &HandleBuffer);
- if (EFI_ERROR (Status)) {
- return (Status);
- }
-
- for (HIndex = 0; HIndex < HandleCount; ++HIndex) {
- // If PciIo opened with EFI_OPEN_PROTOCOL_GET_PROTOCOL, the CloseProtocol() is not required
- Status = gBS->OpenProtocol (
- HandleBuffer[HIndex],
- &gEfiPciIoProtocolGuid,
- (VOID **) PciIo,
- NULL,
- NULL,
- EFI_OPEN_PROTOCOL_GET_PROTOCOL);
- if (EFI_ERROR (Status)) {
- continue;
- }
-
- Status = ReadMarvellYoukonPciId (*PciIo, JUNO_MARVELL_YUKON_ID);
- if (EFI_ERROR (Status)) {
- continue;
- } else {
- break;
- }
- }
-
- gBS->FreePool (HandleBuffer);
-
- return Status;
-}
-
/**
This function restore the original controller attributes

@@ -326,18 +242,14 @@ WriteMacAddress (
**/
STATIC
EFI_STATUS
-ArmJunoSetNicMacAddress ()
+ArmJunoSetNicMacAddress (
+ IN EFI_PCI_IO_PROTOCOL *PciIo
+ )
{
UINT64 OldPciAttr;
- EFI_PCI_IO_PROTOCOL* PciIo;
UINT32 PciRegBase;
EFI_STATUS Status;

- Status = GetMarvellYukonPciIoProtocol (&PciIo);
- if (EFI_ERROR (Status)) {
- return Status;
- }
-
PciRegBase = 0;
Status = InitPciDev (PciIo, &PciRegBase, &OldPciAttr);
if (EFI_ERROR (Status)) {
@@ -352,14 +264,8 @@ ArmJunoSetNicMacAddress ()
}

/**
- Notification function of the event defined as belonging to the
- EFI_END_OF_DXE_EVENT_GROUP_GUID event group that was created in
- the entry point of the driver.
-
- This function is called when an event belonging to the
- EFI_END_OF_DXE_EVENT_GROUP_GUID event group is signalled. Such an
- event is signalled once at the end of the dispatching of all
- drivers (end of the so called DXE phase).
+ This function is called when a gEfiPciIoProtocolGuid protocol instance is
+ registered in the protocol database.

@param[in] Event Event declared in the entry point of the driver whose
notification function is being invoked.
@@ -367,33 +273,30 @@ ArmJunoSetNicMacAddress ()
**/
STATIC
VOID
-OnEndOfDxe (
+PciIoNotificationEvent (
IN EFI_EVENT Event,
IN VOID *Context
)
{
- EFI_DEVICE_PATH_PROTOCOL* PciRootComplexDevicePath;
- EFI_HANDLE Handle;
- EFI_STATUS Status;
+ EFI_STATUS Status;
+ EFI_PCI_IO_PROTOCOL *PciIo;

- //
- // PCI Root Complex initialization
- // At the end of the DXE phase, we should get all the driver dispatched.
- // Force the PCI Root Complex to be initialized. It allows the OS to skip
- // this step.
- //
- PciRootComplexDevicePath = (EFI_DEVICE_PATH_PROTOCOL*) &mPciRootComplexDevicePath;
- Status = gBS->LocateDevicePath (&gEfiPciRootBridgeIoProtocolGuid,
- &PciRootComplexDevicePath,
- &Handle);
+ Status = gBS->LocateProtocol (&gEfiPciIoProtocolGuid,
+ mPciIoNotificationRegistration, (VOID **)&PciIo);
+ if (EFI_ERROR (Status)) {
+ return;
+ }

- Status = gBS->ConnectController (Handle, NULL, PciRootComplexDevicePath, FALSE);
- ASSERT_EFI_ERROR (Status);
+ Status = ReadMarvellYoukonPciId (PciIo, JUNO_MARVELL_YUKON_ID);
+ if (EFI_ERROR (Status)) {
+ return;
+ }

- Status = ArmJunoSetNicMacAddress ();
+ Status = ArmJunoSetNicMacAddress (PciIo);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "ArmJunoDxe: Failed to set Marvell Yukon NIC MAC address\n"));
}
+ gBS->CloseEvent (Event);
}

EFI_STATUS
@@ -408,7 +311,6 @@ ArmJunoEntryPoint (
CHAR16 *TextDevicePath;
UINTN TextDevicePathSize;
UINT32 JunoRevision;
- EFI_EVENT EndOfDxeEvent;

//
// Register the OHCI and EHCI controllers as non-coherent
@@ -497,20 +399,17 @@ ArmJunoEntryPoint (
PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);

//
- // Create an event belonging to the "gEfiEndOfDxeEventGroupGuid" group.
- // The "OnEndOfDxe()" function is declared as the call back function.
- // It will be called at the end of the DXE phase when an event of the
- // same group is signalled to inform about the end of the DXE phase.
- // Install the INSTALL_FDT_PROTOCOL protocol.
+ // Create a protocol notification event handler on the PciIo protocol
+ // so we can set the MAC address on the Marvell Yukon as soon as it
+ // appears.
//
- Status = gBS->CreateEventEx (
- EVT_NOTIFY_SIGNAL,
- TPL_CALLBACK,
- OnEndOfDxe,
- NULL,
- &gEfiEndOfDxeEventGroupGuid,
- &EndOfDxeEvent
- );
+ EfiCreateProtocolNotifyEvent (
+ &gEfiPciIoProtocolGuid,
+ TPL_NOTIFY,
(2) I generally prefer the lowest TPL that works, so I'd suggest
TPL_CALLBACK here.

With (1) updated, and (2) optionally updated (if you agree):

Reviewed-by: Laszlo Ersek <lersek@...>

Thanks!
Laszlo


+ PciIoNotificationEvent,
+ NULL,
+ &mPciIoNotificationRegistration
+ );

#ifndef DYNAMIC_TABLES_FRAMEWORK
// Declare the related ACPI Tables
diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
index 7c118d9c9c6b..d016967c3c37 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.inf
@@ -44,7 +44,6 @@ [LibraryClasses]
UefiDriverEntryPoint

[Guids]
- gEfiEndOfDxeEventGroupGuid
gEfiFileInfoGuid

[Protocols]


[PATCH v2 063/105] .mailmap: Add an entry for Mike Wu

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Mike Wu to have his name and email address
displayed properly in the git history.

Cc: Mike Wu <mike.wu@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Mike Wu doesn't give his
approval, by replying to this patch with:
Reviewed-by: Mike Wu <mike.wu@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Mike Wu <mike.wu@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 6f444ad5a3cd..190d2790b103 100644
--- a/.mailmap
+++ b/.mailmap
@@ -122,3 +122,4 @@ Michael Kinney <michael.d.kinney@...> </o=Intel/ou=Americas01/cn=Workers/c
Michael Kubacki <michael.a.kubacki@...>
Michael Kubacki <michael.a.kubacki@...> </o=Intel/ou=External (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72>
Michael Zimmermann <sigmaepsilon92@...> <[mailto:sigmaepsilon92@...]>
+Mike Wu <mike.wu@...> <mikewuping@6f19259b-4bc3-4df7-8a09-765794883524>
--
2.21.0


[PATCH v2 065/105] .mailmap: Add an entry for Nikolai Saoukh

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Nikolai Saoukh to have his name and email address
displayed properly in the git history.

Cc: Nikolai Saoukh <nms@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Nikolai Saoukh doesn't give his
approval, by replying to this patch with:
Reviewed-by: Nikolai Saoukh <nms@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Nikolai Saoukh <nms@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 9b5351167ca7..a3074feb017c 100644
--- a/.mailmap
+++ b/.mailmap
@@ -124,3 +124,4 @@ Michael Kubacki <michael.a.kubacki@...> </o=Intel/ou=External (FYDIBOHF25S
Michael Zimmermann <sigmaepsilon92@...> <[mailto:sigmaepsilon92@...]>
Mike Wu <mike.wu@...> <mikewuping@6f19259b-4bc3-4df7-8a09-765794883524>
Ming Tan <ming.tan@...>
+Nikolai Saoukh <nms@...>
--
2.21.0


[PATCH v2 064/105] .mailmap: Add an entry for Ming Tan

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Ming Tan to have his name and email address
displayed properly in the git history.

Cc: Ming Tan <ming.tan@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Ming Tan doesn't give his
approval, by replying to this patch with:
Reviewed-by: Ming Tan <ming.tan@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Ming Tan <ming.tan@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 190d2790b103..9b5351167ca7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -123,3 +123,4 @@ Michael Kubacki <michael.a.kubacki@...>
Michael Kubacki <michael.a.kubacki@...> </o=Intel/ou=External (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72>
Michael Zimmermann <sigmaepsilon92@...> <[mailto:sigmaepsilon92@...]>
Mike Wu <mike.wu@...> <mikewuping@6f19259b-4bc3-4df7-8a09-765794883524>
+Ming Tan <ming.tan@...>
--
2.21.0


[PATCH v2 062/105] .mailmap: Add an entry for Michael Zimmermann

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Michael Zimmermann to have his name and email address
displayed properly in the git history.

Cc: Michael Zimmermann <sigmaepsilon92@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Michael Zimmermann doesn't give his
approval, by replying to this patch with:
Reviewed-by: Michael Zimmermann <sigmaepsilon92@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Michael Zimmermann <sigmaepsilon92@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 822a65a6aad7..6f444ad5a3cd 100644
--- a/.mailmap
+++ b/.mailmap
@@ -121,3 +121,4 @@ Michael Kinney <michael.d.kinney@...> <Michael.d.kinney@...>
Michael Kinney <michael.d.kinney@...> </o=Intel/ou=Americas01/cn=Workers/cn=Kinney, Michael D>
Michael Kubacki <michael.a.kubacki@...>
Michael Kubacki <michael.a.kubacki@...> </o=Intel/ou=External (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72>
+Michael Zimmermann <sigmaepsilon92@...> <[mailto:sigmaepsilon92@...]>
--
2.21.0


[PATCH v2 061/105] .mailmap: Add an entry for Michael Kubacki

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Michael Kubacki to have his name and email address
displayed properly in the git history.

Cc: Michael Kubacki <michael.a.kubacki@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Michael Kubacki doesn't give his
approval, by replying to this patch with:
Reviewed-by: Michael Kubacki <michael.a.kubacki@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Michael Kubacki <michael.a.kubacki@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 2 ++
1 file changed, 2 insertions(+)

diff --git a/.mailmap b/.mailmap
index a8bffe9d4729..822a65a6aad7 100644
--- a/.mailmap
+++ b/.mailmap
@@ -119,3 +119,5 @@ Michael Kinney <michael.d.kinney@...> <mdkinney@Edk2>
Michael Kinney <michael.d.kinney@...> <mdkinney@...>
Michael Kinney <michael.d.kinney@...> <Michael.d.kinney@...>
Michael Kinney <michael.d.kinney@...> </o=Intel/ou=Americas01/cn=Workers/cn=Kinney, Michael D>
+Michael Kubacki <michael.a.kubacki@...>
+Michael Kubacki <michael.a.kubacki@...> </o=Intel/ou=External (FYDIBOHF25SPDLT)/cn=Recipients/cn=3c8b0226e75f4ab08d20c151cb7a8a72>
--
2.21.0


[PATCH v2 059/105] .mailmap: Add an entry for Michael Johnson

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Michael Johnson to have his name and email address
displayed properly in the git history.

Cc: Michael Johnson <michael.johnson@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Michael Johnson doesn't give his
approval, by replying to this patch with:
Reviewed-by: Michael Johnson <michael.johnson@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Michael Johnson <michael.johnson@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index 42a54c6c6f6f..9c1b05fca786 100644
--- a/.mailmap
+++ b/.mailmap
@@ -112,3 +112,4 @@ Mateusz Albecki <mateusz.albecki@...>
Mateusz Albecki <mateusz.albecki@...> </o=Intel/ou=Exchange Administrative Group (FYDIBOHF23SPDLT)/cn=Recipients/cn=Albecki, Mateusz3be>
Maurice Ma <maurice.ma@...>
Maxim Shvecov <Gris87@...>
+Michael Johnson <michael.johnson@...>
--
2.21.0


[PATCH v2 060/105] .mailmap: Add an entry for Michael Kinney

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Michael Kinney to have his name and email address
displayed properly in the git history.

Cc: Michael Kinney <michael.d.kinney@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Michael Kinney doesn't give his
approval, by replying to this patch with:
Reviewed-by: Michael Kinney <michael.d.kinney@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Michael Kinney <michael.d.kinney@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/.mailmap b/.mailmap
index 9c1b05fca786..a8bffe9d4729 100644
--- a/.mailmap
+++ b/.mailmap
@@ -113,3 +113,9 @@ Mateusz Albecki <mateusz.albecki@...> </o=Intel/ou=Exchange Administrative
Maurice Ma <maurice.ma@...>
Maxim Shvecov <Gris87@...>
Michael Johnson <michael.johnson@...>
+Michael Kinney <michael.d.kinney@...>
+Michael Kinney <michael.d.kinney@...> <mdkinney@6f19259b-4bc3-4df7-8a09-765794883524>
+Michael Kinney <michael.d.kinney@...> <mdkinney@Edk2>
+Michael Kinney <michael.d.kinney@...> <mdkinney@...>
+Michael Kinney <michael.d.kinney@...> <Michael.d.kinney@...>
+Michael Kinney <michael.d.kinney@...> </o=Intel/ou=Americas01/cn=Workers/cn=Kinney, Michael D>
--
2.21.0


[PATCH v2 058/105] .mailmap: Add an entry for Maxim Shvecov

Philippe Mathieu-Daudé <philmd@...>
 

We use .mailmap to display contributors email addresses in an
uniform format.

Add an entry for Maxim Shvecov to have his name and email address
displayed properly in the git history.

Cc: Maxim Shvecov <Gris87@...>
Signed-off-by: Philippe Mathieu-Daude <philmd@...>
---
[Due to MTA restricting the recipient list to 100, I can not Cc all the
named developers in the cover. Therefore I'm adapting the explaination
from the cover in each patch]

This patch won't get merged if Maxim Shvecov doesn't give his
approval, by replying to this patch with:
Reviewed-by: Maxim Shvecov <Gris87@...>

If you think this patch is inappropriate, you don't need to justify,
reply with:
NAcked-by: Maxim Shvecov <Gris87@...>
or simply:
NACK

If your Firstname Lastname order is incorrect, tell me and I will fix it.

You can also ignore this mail, but I might resend it and keep bothering
you.

Regards,

Phil.
---
.mailmap | 1 +
1 file changed, 1 insertion(+)

diff --git a/.mailmap b/.mailmap
index ce558e39b1b5..42a54c6c6f6f 100644
--- a/.mailmap
+++ b/.mailmap
@@ -111,3 +111,4 @@ Marvin Häuser <mhaeuser@...>
Mateusz Albecki <mateusz.albecki@...>
Mateusz Albecki <mateusz.albecki@...> </o=Intel/ou=Exchange Administrative Group (FYDIBOHF23SPDLT)/cn=Recipients/cn=Albecki, Mateusz3be>
Maurice Ma <maurice.ma@...>
+Maxim Shvecov <Gris87@...>
--
2.21.0