Re: [PATCH v1] [PATCH v1] UefiCpuPkg: Check SMM Delayed/Blocked AP Count to decide all CPUs in SMI or not


Ni, Ray
 

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4173

The blocked register might return the counter instead of bitvector. This
request
is to update the code to handle the case by checking SMM Delayed/Blocked
AP Count
to decide all CPUs in SMI or not.
The code change actually assumes the SmmRegSmmBlocked, SmmRegSmmDelayed
and SmmRegSmmEnable registers return the number of threads that are in
blocked, delayed or disabled state.
Can you provide suggestions regarding how to change those close source CpuSmmFeaturesLib
implementation which still returns the bitmap value instead of count in the commit message?


+UINT32 *mPackageBspInfo = NULL;
The variable name is confusing. Can you rename it to "mPackageFirstThreadIndex"?

Join devel@edk2.groups.io to automatically receive all group messages.