Re: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.


Wu, Jiaxin
 

Reviewed-by: Jiaxin Wu <jiaxin.wu@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Saturday, October 8, 2022 2:34 PM
To: Li, Zhihao <zhihao.li@...>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@...>
Subject: Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter
when BSP Exit in CPU relaxed mode.

Reviewed-by: Ray Ni <ray.ni@...>

-----Original Message-----
From: Li, Zhihao <zhihao.li@...>
Sent: Tuesday, September 27, 2022 8:58 PM
To: devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@...>; Ni, Ray <ray.ni@...>
Subject: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in
CPU relaxed mode.

From: Zhihao Li <zhihao.li@...>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083

In CPU relaxed mode, it doesn't reset the value of
mSmmMpSyncData->AllApArrivedWithException when BSP exit smm
mode.
So this patch will reset this variable.

Cc: Eric Dong <eric.dong@...>
Cc: Ray Ni <ray.ni@...>

Signed-off-by: Zhihao Li <zhihao.li@...>
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 13c2cb8da4c3..c79da418e37c 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -696,8 +696,9 @@ BSPHandler (
//

// Allow APs to check in from this point on

//

- *mSmmMpSyncData->Counter = 0;

- *mSmmMpSyncData->AllCpusInSync = FALSE;

+ *mSmmMpSyncData->Counter = 0;

+ *mSmmMpSyncData->AllCpusInSync = FALSE;

+ mSmmMpSyncData->AllApArrivedWithException = FALSE;

}



/**

--
2.26.2.windows.1



Join {devel@edk2.groups.io to automatically receive all group messages.