Re: [RFC] Adoption of CodeQL in edk2


Ni, Ray
 

Multiplication result converted to larger type · Code scanning alert #66 · tianocore/edk2 (github.com)

Michael, I do not think above issue is a real issue. Will them be required to fix before enabling te CodeQL?

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney
Sent: Friday, September 30, 2022 9:03 AM
To: devel@edk2.groups.io; mikuback@...; Kinney, Michael D <michael.d.kinney@...>
Subject: Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2

 

I just want to reiterate.  If there are no concerns or objections raised by Oct 4, then the

CodeQL static analysis will be phased into use in the edk2 repo and there will be code

changes made to address the issues identified by COdeQL and all future code changes

after a CodeQL check is enabled will be blocked until the CodeQL CI checks pass.

 

This will impact all future code changes and all developers will have to learn how to

interpret CodeQL reports and fix issues.

 

Thanks,

 

Mike

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Kubacki
Sent: Thursday, September 29, 2022 5:05 PM
To: Michael Kubacki <mikuback@...>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2

 

If there's any further feedback on this RFC, please respond by Tuesday, October 4th. We plan to start implementing the changes later in the week.

Thanks,
Michael

Join devel@edk2.groups.io to automatically receive all group messages.