Re: [PATCH v4 3/6] OvmfPkg: set PcdEnableUnacceptedMemory to FALSE

Dionna Glaze

Generally, we tend to rely on the DEC default for new PCDs if we're
not deviating from it.
If there is no specific reason to deviate from this here, I think we
can drop this patch.

Or is this also needed to declare them as the right type? In that
case, I think you can drop the hunks that touch non-CC platforms.
I probably did something wrong. Without this patch, the protocol patch
with PcdSetBoolS fails to build.

INFO - In file included from
INFO - from <command-line>:
INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdeModulePkg/Core/Dxe/Mem/Page.c:
In function ‘CoreEnableUnacceptedMemory’:
INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdePkg/Include/Library/PcdLib.h:549:40:
error: implicit declaration of function
INFO - 549 | #define PcdSetBoolS(TokenName, Value)
_PCD_SET_MODE_BOOL_S_##TokenName ((Value))
INFO - | ^~~~~~~~~~~~~~~~~~~~~
INFO - /usr/local/google/home/dionnaglaze/gitrepos/edk2/MdeModulePkg/Core/Dxe/Mem/Page.c:2232:10:
note: in expansion of macro ‘PcdSetBoolS’
INFO - 2232 | return PcdSetBoolS(PcdAcceptAllUnacceptedMemory, FALSE);
INFO - | ^~~~~~~~~~~
INFO - cc1: all warnings being treated as errors
INFO - make: *** [GNUmakefile:452:
Error 1

What's the right way to do this?

-Dionna Glaze, PhD (she/her)

Join to automatically receive all group messages.