回复: [edk2-devel] [PATCH 3/6] BaseTools/VolInfo: Increase GUID base name string


gaoliming
 

Reviewed-by: Liming Gao <gaoliming@...>

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Konstantin
Aladyshev
发送时间: 2022年8月30日 18:15
收件人: devel@edk2.groups.io
抄送: bob.c.feng@...; gaoliming@...;
yuwei.chen@...; Konstantin Aladyshev <aladyshev22@...>
主题: [edk2-devel] [PATCH 3/6] BaseTools/VolInfo: Increase GUID base name
string

The current string lenght (=60) is not enough for cases where basename
is a path to Build folder.
Drop custom define and use MAX_LINE_LEN from the BaseTools codebase
instead.

Signed-off-by: Konstantin Aladyshev <aladyshev22@...>
---
BaseTools/Source/C/VolInfo/VolInfo.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c
b/BaseTools/Source/C/VolInfo/VolInfo.c
index 4628e756d7..d9be3d8c18 100644
--- a/BaseTools/Source/C/VolInfo/VolInfo.c
+++ b/BaseTools/Source/C/VolInfo/VolInfo.c
@@ -51,15 +51,13 @@ EFI_GUID
gEfiCrc32GuidedSectionExtractionProtocolGuid =
EFI_CRC32_GUIDED_SECTIO


#define EFI_SECTION_ERROR EFIERR (100)



-#define MAX_BASENAME_LEN 60 // not good to hardcode, but let's be
reasonable

-

//

// Structure to keep a list of guid-to-basenames

//

typedef struct _GUID_TO_BASENAME {

struct _GUID_TO_BASENAME *Next;

INT8 Guid[PRINTED_GUID_BUFFER_SIZE];

- INT8 BaseName[MAX_BASENAME_LEN];

+ INT8 BaseName[MAX_LINE_LEN];

} GUID_TO_BASENAME;



static GUID_TO_BASENAME *mGuidBaseNameList = NULL;

--
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92970): https://edk2.groups.io/g/devel/message/92970
Mute This Topic: https://groups.io/mt/93345658/4905953
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub
[gaoliming@...]
-=-=-=-=-=-=

Join devel@edk2.groups.io to automatically receive all group messages.