Re: [PATCH v2 0/3] OvmfPkg: Check arguments for validity


Ard Biesheuvel
 

On Mon, 15 Aug 2022 at 18:31, Dimitrije Pavlov <dimitrije.pavlov@...> wrote:

Some functions across OVMF don't check pointer arguments for
validity, which causes null pointer dereferences and crashes
in the SCT test suite.

This series adds checks to return EFI_INVALID_PARAMETER if a
pointer argument is NULL.

v2:
- Add Liming Gao to Cc [Ard]
- Turn individual patches into a series [Ard]
- Fix issue with corrupted patches [Ard]

Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Jiewen Yao <jiewen.yao@...>
Cc: Liming Gao <gaoliming@...>
Cc: Sunny Wang <Sunny.Wang@...>
Cc: Jeff Booher-Kaeding <Jeff.Booher-Kaeding@...>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@...>

Dimitrije Pavlov (3):
OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments
OvmfPkg/VirtioGpuDxe: Check QueryMode arguments
OvmfPkg/VirtioFsDxe: Check GetDriverName arguments
Thank you for the resend.

@Liming: these are all bug fixes that affect SCT results, so unless
there are any objections, I intend to merge these tomorrow (Tuesday).

Thanks,
Ard.

Join {devel@edk2.groups.io to automatically receive all group messages.