Re: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host interface is not supported


Chang, Abner
 

[AMD Official Use Only - General]

Hi Igor,
Just found that you don't have the CC for maintainers and your Signed-off-by tag in the commit message.
You can refer to below link for the correct commit message format for the patch.
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers

Thanks
Abner

-----Original Message-----
From: Igor Kulchytskyy <igork@...>
Sent: Thursday, August 4, 2022 11:25 PM
To: Chang, Abner <Abner.Chang@...>
Cc: nickle.wang@...; Igor Kulchytskyy <igork@...>;
devel@edk2.groups.io
Subject: [PATCH] RedfishPkg: RedfishDiscoverDxe: USB Redfish host
interface is not supported

[CAUTION: External Email]

Host Interface details are discribed by the SMBIOS Type 42 table.
The table is published by the RedfishHostInterfaceDxe driver.
That driver supports PCI-E and USB host interface types.
The table is consumed by the RedfishGetHostInterfaceProtocolData function
in the RedfishDiscoverDxe driver.
That function only supports PCI-E interface.
---
RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c | 11
++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
index d79750b..a3b977f 100644
--- a/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
+++ b/RedfishPkg/RedfishDiscoverDxe/RedfishSmbiosHostInterface.c
@@ -65,10 +65,15 @@ RedfishGetHostInterfaceProtocolData (
RecordTmp = (UINT8 *)Record + Offset;

//
- // Check Device Type, only PCI/PCIe Network Interface v2 is supported
now.
+ // Check Device Type, PCI/PCIe and USB Network Interface v2 is
supported.
//
- if (*RecordTmp ==
REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) {
- ASSERT (SpecificDataLen == sizeof
(PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
+ if ((*RecordTmp ==
REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2) || (*RecordTmp ==
REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2)) {
+ if (*RecordTmp ==
REDFISH_HOST_INTERFACE_DEVICE_TYPE_PCI_PCIE_V2){
+ ASSERT (SpecificDataLen == sizeof
(PCI_OR_PCIE_INTERFACE_DEVICE_DESCRIPTOR_V2) + 1);
+ }
+ if (*RecordTmp ==
REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2){
+ ASSERT (SpecificDataLen > sizeof
(REDFISH_HOST_INTERFACE_DEVICE_TYPE_USB_V2) + 1);
+ }
*DeviceDescriptor = (REDFISH_INTERFACE_DATA *)RecordTmp;
Offset = Offset + SpecificDataLen;
RecordTmp = (UINT8 *)Record + Offset;
--
2.6.1.windows.1
-The information contained in this message may be confidential and
proprietary to American Megatrends (AMI). This communication is intended
to be read only by the individual or entity to whom it is addressed or by their
designee. If the reader of this message is not the intended recipient, you are
on notice that any distribution of this message, in any form, is strictly
prohibited. Please promptly notify the sender by reply e-mail or by
telephone at 770-246-8600, and then delete or destroy all copies of the
transmission.

Join devel@edk2.groups.io to automatically receive all group messages.