Re: [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support to EDK2

Wu, Hao A

-----Original Message-----
From: <> On Behalf Of Wu, Hao
Sent: Tuesday, August 2, 2022 10:21 AM
To:; Czajkowski, Maciej
Cc: Gao, Liming <gaoliming@...>; Ni, Ray <>
Subject: Re: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI
support to EDK2

Thanks, the series look good to me. I have given my R-B tag for both of the
Will wait some time to see if there are comments from other reviewers. If no
further feedback received, I will merge the series before the end of this

Best Regards,
Hao Wu

-----Original Message-----
From: <> On Behalf Of Maciej
Sent: Tuesday, August 2, 2022 1:00 AM
Subject: [edk2-devel] [PATCH v3 0/2] Add EDKII_PCI_DEVICE_PPI support


The purpose of those changes is to introduce the way to enumerate and
assign resources in PEI for the systems with more than one PCI root.
Here is a need to have an interface that will support such a mechanizm.
For now, the part that performs the enumeration will be implemented in
the silicon code.
Sample code can be seen here:


v2 changes:
- collected Acked-by tag for no.1 commit
- followed-up with change suggestions in no.2 commit

v3 changes:
- no.1 commit: picked up reviewed-by tag
- no.2 commit: a few fixes based on v2 review

Maciej Czajkowski (2):
MdeModulePkg: Add EDKII_PCI_DEVICE_PPI definition
MdeModulePkg/AhciPei: Use PCI_DEVICE_PPI to manage AHCI device

MdeModulePkg/Bus/Ata/AhciPei/AhciPei.c | 505 +++++++++++++-------
MdeModulePkg/Bus/Ata/AhciPei/DevicePath.c | 44 --
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.h | 57 ++-
MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf | 5 +-
MdeModulePkg/Include/Ppi/PciDevice.h | 32 ++
MdeModulePkg/MdeModulePkg.dec | 3 +
MdeModulePkg/MdeModulePkg.dsc | 1 +
7 files changed, 425 insertions(+), 222 deletions(-) create mode
100644 MdeModulePkg/Include/Ppi/PciDevice.h


Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII
Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP
07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
adresata i moze zawierac informacje poufne. W razie przypadkowego
otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale
jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). If you are not the intended
recipient, please contact the sender and delete all copies; any review
or distribution by others is strictly prohibited.

Join { to automatically receive all group messages.