回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for PEIMs


gaoliming
 

This change has been merged in edk2 master.

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
groups.io
发送时间: 2022年7月13日 15:48
收件人: devel@edk2.groups.io; Kun.Qin@...; 'Kinney, Michael D'
<michael.d.kinney@...>; 'Albecki, Mateusz'
<mateusz.albecki@...>
抄送: 'Liu, Zhiguang' <zhiguang.liu@...>
主题: 回复: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib:
Add support for PEIMs


That's great. I give my reviewed-by for this patch. Reviewed-by: Liming Gao
<gaoliming@...>

Thanks
Liming
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin via
groups.io
发送时间: 2022年7月12日 5:30
收件人: gaoliming <gaoliming@...>; devel@edk2.groups.io;
Kinney, Michael D <michael.d.kinney@...>; 'Albecki, Mateusz'
<mateusz.albecki@...>
抄送: 'Liu, Zhiguang' <zhiguang.liu@...>
主题: Re: 回复: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib:
Add
support for PEIMs

Liming/Mike,

I think making MM instance to be a base version makes sense, too. Thanks
for
the suggestion.

Regards,
Kun

-----Original Message-----
From: gaoliming <gaoliming@...>
Sent: Sunday, July 10, 2022 11:49 PM
To: devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>;
'Albecki, Mateusz' <mateusz.albecki@...>
Cc: 'Liu, Zhiguang' <zhiguang.liu@...>; Kun Qin
<Kun.Qin@...>
Subject: [EXTERNAL] 回复: [edk2-devel] [PATCHv3 1/1]
MdePkg/UefiDevicePathLib: Add support for PEIMs

Mike:
Thanks for your suggestion. If there is no objection to change the file
name,
this patch will be better.

Thanks
Liming
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
D
Kinney
发送时间: 2022年7月8日 6:06
收件人: Gao, Liming <gaoliming@...>; Albecki, Mateusz
<mateusz.albecki@...>; devel@edk2.groups.io; Kinney, Michael D
<michael.d.kinney@...>
抄送: Liu, Zhiguang <zhiguang.liu@...>
主题: Re: [edk2-devel] [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add
support for PEIMs

Hi Liming,

I think the current Mm specific INF is actually compatible with all
module types.

Why not add a Base version that can be used by any module?

Using Peim in name implies it is only compatible with PEIMs which is not
true.

For the compatibility question, I would like to see feedback from Mm
maintainers to see if they would accept a library name change to a
more general purpose Base INF.

Mike

-----Original Message-----
From: gaoliming <gaoliming@...>
Sent: Wednesday, July 6, 2022 6:37 PM
To: Albecki, Mateusz <mateusz.albecki@...>;
devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@...>; Liu, Zhiguang
<zhiguang.liu@...>
Subject: 回复: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support
for
PEIMs

Mateusz:
To be compatible, I suggest to add one new
UefiDevicePathLibPeim.inf
for
PEIM module. It will be same to UefiDevicePathLibStandaloneMm.inf
except for
module type and base name.

The source file rename is the compatible change. It can be made.

Thanks
Liming
-----邮件原件-----
发件人: Mateusz Albecki <mateusz.albecki@...>
发送时间: 2022年7月1日 22:12
收件人: devel@edk2.groups.io
抄送: Mateusz Albecki <mateusz.albecki@...>; Michael D
Kinney
<michael.d.kinney@...>; Liming Gao
<gaoliming@...>; Zhiguang Liu <zhiguang.liu@...>
主题: [PATCHv3 1/1] MdePkg/UefiDevicePathLib: Add support for
PEIMs

DevicePathLib utilities are useful in PEI to locate the devices
which need an opal unlock on S3 resume. This commit reuses the
implementation
done
for standalone MM support and makes the StandaloneMm library
Base.

Signed-off-by: Mateusz Albecki <mateusz.albecki@...>

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Zhiguang Liu <zhiguang.liu@...>

---
...athUtilitiesStandaloneMm.c => DevicePathUtilitiesBase.c} | 0
...icePathLibStandaloneMm.inf => UefiDevicePathLibBase.inf} | 6
+++--- MdePkg/MdePkg.dsc
|
2 +-
3 files changed, 4 insertions(+), 4 deletions(-) rename
MdePkg/Library/UefiDevicePathLib/{DevicePathUtilitiesStandaloneMm.
c
=>
DevicePathUtilitiesBase.c} (100%)
rename
MdePkg/Library/UefiDevicePathLib/{UefiDevicePathLibStandaloneMm.in
f
=>
UefiDevicePathLibBase.inf} (87%)

diff --git
a/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
b/MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
similarity index 100%
rename from
MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesStandaloneMm.c
rename to
MdePkg/Library/UefiDevicePathLib/DevicePathUtilitiesBase.c
diff --git
a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
similarity index 87%
rename from
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
rename to
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
index 23fedf38b7..323043033f 100644
---
a/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
+++ b/MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
@@ -16,10 +16,10 @@
BASE_NAME = UefiDevicePathLib
MODULE_UNI_FILE = UefiDevicePathLib.uni
FILE_GUID =
D8E58437-44D3-4154-B7A7-EB794923EF12
- MODULE_TYPE = MM_STANDALONE
+ MODULE_TYPE = BASE
PI_SPECIFICATION_VERSION = 0x00010032
VERSION_STRING = 1.0
- LIBRARY_CLASS = DevicePathLib |
MM_STANDALONE MM_CORE_STANDALONE
+ LIBRARY_CLASS = DevicePathLib


#
@@ -28,7 +28,7 @@

[Sources]
DevicePathUtilities.c
- DevicePathUtilitiesStandaloneMm.c
+ DevicePathUtilitiesBase.c
DevicePathToText.c
DevicePathFromText.c
UefiDevicePathLib.c
diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc index
3d8874e647..9daee93523 100644
--- a/MdePkg/MdePkg.dsc
+++ b/MdePkg/MdePkg.dsc
@@ -111,7 +111,7 @@

MdePkg/Library/UefiDebugLibDebugPortProtocol/UefiDebugLibDebugPortPro
tocol.inf
MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
-
MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibStandaloneMm.inf
+ MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf

MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibOptionalDevicePathPr
o
tocol.inf

MdePkg/Library/UefiDevicePathLibDevicePathProtocol/UefiDevicePathLibDe
vicePathProtocol.inf
MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
--
2.28.0.windows.1

------------------------------------------------------------------
--- Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc |
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 |
NIP
957-07-52-316 | Kapital zakladowy 200.000 PLN.
Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego
adresata i moze zawierac informacje poufne. W razie przypadkowego
otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz
trwale
jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie
jest zabronione.
This e-mail and any attachments may contain confidential material
for the sole use of the intended recipient(s). If you are not the
intended
recipient,
please contact the sender and delete all copies; any review or
distribution by
others is strictly prohibited.













Join devel@edk2.groups.io to automatically receive all group messages.