Re: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec


Ni, Ray
 

Reviewed-by: Ray Ni <ray.ni@...>

-----Original Message-----
From: Guo, Gua <gua.guo@...>
Sent: Monday, June 27, 2022 1:03 PM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@...>; Lu, James <james.lu@...>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

Yes, #2 is chosen in by the python interpreter.

-----Original Message-----
From: Guo, Gua
Sent: Monday, June 27, 2022 12:07 PM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@...>; Lu, James <james.lu@...>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

The python logic will like for below

upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
=========>
if BuildTarget == "DEBUG":
upld_info_hdr.Attribute |= 1
else:
upld_info_hdr.Attribute |= 0
Thanks,
Gua

-----Original Message-----
From: Ni, Ray <ray.ni@...>
Sent: Monday, June 27, 2022 11:44 AM
To: Guo, Gua <gua.guo@...>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@...>; Lu, James <james.lu@...>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

+ upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0

I am not python expert. Above statement might be interpreted as:
1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. upld_info_hdr.Attribute |= (1 if BuildTarget ==
"DEBUG" else 0)

Are we sure that the #2 is chosen in by the python interpreter?

Join devel@edk2.groups.io to automatically receive all group messages.