Re: [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message


Yuwei Chen
 

Reviewed-by: Yuwei Chen<yuwei.chen@...>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
Cran
Sent: Monday, June 20, 2022 6:07 AM
To: devel@edk2.groups.io; Feng, Bob C <bob.c.feng@...>; Gao, Liming
<gaoliming@...>; Chen, Christine <yuwei.chen@...>
Cc: Rebecca Cran <quic_rcran@...>
Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error
message

Signed-off-by: Rebecca Cran <quic_rcran@...>
---
BaseTools/Source/Python/Ecc/c.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/BaseTools/Source/Python/Ecc/c.py
b/BaseTools/Source/Python/Ecc/c.py
index 4a82e5e76003..61ad084fcc5b 100644
--- a/BaseTools/Source/Python/Ecc/c.py
+++ b/BaseTools/Source/Python/Ecc/c.py
@@ -2612,8 +2612,8 @@ def
CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier,
FuncHeader, Fu


if Tag.find(ParamName) == -1 and ParamName != 'VOID' and
ParamName != 'void':
- ErrorMsgList.append('Line %d : in Comment, <%s> does NOT
consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
- PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
Comment, <%s> does NOT consistent with parameter name %s ' %
((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
ParamName), TableName, CommentId)
+ ErrorMsgList.append('Line %d : in Comment, <%s> is NOT
consistent with parameter name %s ' % (CommentStartLine, (TagPartList[0] +
' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), ParamName))
+ PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in
Comment, <%s> is NOT consistent with parameter name %s ' %
((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''),
ParamName), TableName, CommentId)
Index += 1

if Index < ParamNumber:
--
2.35.3




Join devel@edk2.groups.io to automatically receive all group messages.