- 回复: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib
回复: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib
toggle quoted messageShow quoted text
Yes. You can merge this patch with my ACK.
发件人: Pedro Falcato <pedro.falcato@...>
发送时间: 2022年6月13日 22:45
收件人: gaoliming <gaoliming@...>
抄送: edk2-devel-groups-io <email@example.com>; Leif Lindholm <leif@...>; Michael D Kinney <michael.d.kinney@...>; Zhiguang Liu <zhiguang.liu@...>
主题: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib
Sorry for the question, but can I merge this with your Ack and my RB or do I have to wait for another RB?
I want to solve this as soon as possible since right now Ext4Pkg won't build with upstream edk2.
On Thu, Jun 2, 2022 at 4:05 AM gaoliming <gaoliming@...> wrote:
Thanks for your enhancement to support ext2/3 file system. Acked-by: Liming Gao <gaoliming@...> for this patch set.
Ping. Please review now that the stable freeze is over.
Ping. Could someone review these patches?
Ping. If someone could take a look, it would be much appreciated.
This patch-set attempts to address two open feature requests for Ext4Pkg
by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib (id 3871).
The previous patch-set regarding 3871 attempted to merge the different crc16 implementations
but failed because, contrary to what I thought, there are many, many different CRC16s which
are all slightly different. This one (plus the separate edk2 patch) attempts to just merge
CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.
Since this patch set grew to be considerably different from the original, I didn't mark it
as v2 but rather a separate, new patch-set.
CC'ing the edk2-platforms stewards (as I cannot review my own code) and the CC's of the MdePkg
Cc: Leif Lindholm <leif@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Pedro Falcato (3):
Ext4Pkg: Replace the CRC implementations with BaseLib
Ext4Pkg: Format using uncrustify
Ext4Pkg: Add ext2/3 support
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +-
Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++
Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +-
Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 -----
Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------
Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +-
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++---
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +-
Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +-
Features/Ext4Pkg/Ext4Dxe/File.c | 19 +-
Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +-
Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +-
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +-
16 files changed, 640 insertions(+), 487 deletions(-)
create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c
Join firstname.lastname@example.org to automatically receive all group messages.