Re: [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options


Ashish Singhal
 

That will not work either in all scenarios as the sort function will need to be a part of the caller. If the caller is an entity in edk2, then having a custom sort function cannot be achieved without a NULL library also being added to edk2 that can be custom implemented by the user.

Thanks
Ashish


From: Ni, Ray <ray.ni@...>
Sent: Thursday, May 26, 2022 7:29 AM
To: Ashish Singhal <ashishsingha@...>; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao <zhichao.gao@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options
 
External email: Use caution opening links or attachments

Yes. UefiBootManagerLib is a fundamental BDS library. Please change the caller.

 

From: Ashish Singhal <ashishsingha@...>
Sent: Thursday, May 26, 2022 9:17 PM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao <zhichao.gao@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

 

I understand that. What do you suggest then? Using EfiBootManagerSortLoadOptionVariable() is an option only if we update all code paths where we refresh the boot options.


From: Ni, Ray <ray.ni@...>
Sent: Thursday, May 26, 2022 7:15 AM
To: Ashish Singhal <ashishsingha@...>; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao <zhichao.gao@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

 

External email: Use caution opening links or attachments

 

  1. I don’t like PCD. It’s like a out-of-band control of library API.
  2. The PCD doesn’t take care of all scenarios. Someone may like to put new options just before the last one.

 

From: Ashish Singhal <ashishsingha@...>
Sent: Wednesday, May 18, 2022 12:09 AM
To: Ni, Ray <ray.ni@...>; devel@edk2.groups.io; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao <zhichao.gao@...>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

 

Ray,

 

Won't that mean changing UEFI UI and boot maintenance manager applications as well to make this call? If we do not do that, the applications would not reflect the sorted boot order automatically.

 

Considering this, the change I have is pretty small and takes care of all scenarios. Please let me know what you think.

 

Thanks

Ashish


From: Ni, Ray <ray.ni@...>
Sent: Tuesday, May 17, 2022 8:11 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Ashish Singhal <ashishsingha@...>; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao <zhichao.gao@...>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options

 

External email: Use caution opening links or attachments


Please use the EfiBootManagerSortLoadOptionVariable() to sort the boot options from PlatformBootManagerLib.


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ashish Singhal via groups.io
> Sent: Tuesday, May 17, 2022 7:02 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@...>; Gao, Liming <gaoliming@...>; Gao, Zhichao
> <zhichao.gao@...>; Ni, Ray <ray.ni@...>
> Cc: Ashish Singhal <ashishsingha@...>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Configurable New Boot Options
>
> Add a new PCD to be able to configure whether newly detected boot options
> are to be added at the beginning of the current boot options list or at
> the end.
>
> Signed-off-by: Ashish Singhal <ashishsingha@...>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c            | 6 +++++-
>  .../Library/UefiBootManagerLib/UefiBootManagerLib.inf       | 1 +
>  MdeModulePkg/MdeModulePkg.dec                               | 5 +++++
>  MdeModulePkg/MdeModulePkg.uni                               | 4 ++++
>  4 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> index 962892d38f..8a46100c2a 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c
> @@ -2435,7 +2435,11 @@ EfiBootManagerRefreshAllBootOption (
>    //
>    for (Index = 0; Index < BootOptionCount; Index++) {
>      if (EfiBootManagerFindLoadOption (&BootOptions[Index], NvBootOptions, NvBootOptionCount) == -1) {
> -      EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], (UINTN)-1);
> +      if (PcdGetBool (PcdNewBootOptionAtStart)) {
> +        EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], 0);
> +      } else {
> +        EfiBootManagerAddLoadOptionVariable (&BootOptions[Index], (UINTN)-1);
> +      }
>        //
>        // Try best to add the boot options so continue upon failure.
>        //
> diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..46f41a7c63 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -119,3 +119,4 @@
>    gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile                     ## CONSUMES
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDriverHealthConfigureForm               ## SOMETIMES_CONSUMES
>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxRepairCount                          ## CONSUMES
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdNewBootOptionAtStart                    ## CONSUMES
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index cf79292ec8..9d696f117b 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -2146,6 +2146,11 @@
>    # @Prompt GHCB Pool Size
>    gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbSize|0|UINT64|0x00030008
>
> +  ## This dynamic PCD holds the flag to tell UEFI boot manager whether to add newly detected devices at
> +  #  the end, or at the start of the boot option.
> +  # @Prompt Add new devices in boot options at start
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdNewBootOptionAtStart|FALSE|BOOLEAN|0x00030009
> +
>  [PcdsDynamicEx]
>    ## This dynamic PCD enables the default variable setting.
>    #  Its value is the default store ID value. The default value is zero as Standard default.
> diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index b070f15ff2..8e68db1c25 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1325,6 +1325,10 @@
>
>  #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbBase_HELP #language en-US "Used with SEV-ES support to identify
> an address range that is not to be encrypted."
>
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNewBootOptionAtStart_PROMPT #language en-US "Add new devices in
> boot options at start"
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdNewBootOptionAtStart_HELP #language en-US "Used by UEFI boot
> manager to decide whether to place newly detcted devices at start of the list or end."
> +
>  #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_PROMPT #language en-US "Guest-Hypervisor Communication
> Block (GHCB) Pool Base Size"
>
>  #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdGhcbSize_HELP #language en-US "Used with SEV-ES support to identify the
> size of the address range that is not to be encrypted."
> --
> 2.17.1
>
>
>
>
>

Join devel@edk2.groups.io to automatically receive all group messages.