Re: [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment


Sheng Lean Tan
 

Hi Star & Liming,
Any update on this?
Much appreciated.

Best Regards,
Lean Sheng Tan



9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany

Registered office: Bochum
Commercial register: Amtsgericht Bochum, HRB 17519
Management: Sebastian German, Eray Bazaar


On Mon, 16 May 2022 at 11:03, Wu, Hao A <hao.a.wu@...> wrote:

Sorry Star and Liming,

 

For the below patch (removing the alignment check for WorkSpace & SpareArea):

https://edk2.groups.io/g/devel/message/89742

 

Do you think it will impact the FTW service on flash device? Thanks in advance.

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, May 16, 2022 3:54 PM
To: Wu, Hao A <hao.a.wu@...>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

 

The bug discovered was with coreboot, and the PCD values are derived from the block size of its SMMStore (NvStorage) region. The discussion on the patch can be found here: https://review.coreboot.org/c/coreboot/+/62990

 

Hacking the PCDs could work,, but why would we want to keep an incorrect check?

 

Thanks!

 

 

On Mon, 16 May 2022 at 08:36, Wu, Hao A <hao.a.wu@...> wrote:

Sorry for not being clear on what I mean.

Is it possible to change the platform PCD values and keep these block size alignment requirements.

 

Best Regards,

Hao Wu

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sean Rhodes
Sent: Monday, May 16, 2022 3:00 PM
To: Wu; Wu, Hao A <hao.a.wu@...>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/FaultTolerantWriteDxe: Don't check for address alignment

 

Hi Hao

Yes, it does conflict - I will update the patch to fix these comments :)

Thank you

Join devel@edk2.groups.io to automatically receive all group messages.