Re: [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs

Michael Kubacki

Can someone seriously respond?

This was approved over 3 weeks ago and sent 5 weeks ago. I know Ankit now has a similar change out but I'd like to see if this can get in and that be rebased on it since this has been out for so long and has the primary change needed for our integration.


On 5/13/2022 1:42 PM, Michael Kubacki wrote:
On 5/10/2022 1:34 PM, Michael Kubacki wrote:
Another reminder to look at this patch.


On 4/29/2022 4:07 PM, Michael Kubacki wrote:
Another reminder to merge this series. Chasel has added his review and that is in this branch:


On 4/22/2022 10:04 AM, Michael Kubacki wrote:
Reminder to review this series.

Ankit Sinha has reviewed it but need a maintainer to review and merge.

On 4/11/2022 4:58 PM, Michael Kubacki wrote:
From: Michael Kubacki <michael.kubacki@...>


Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers
(board packages) can customize the DUTY_OFFSET and DUTY_CYCLE
values in their build files.

The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to
keep the change in sync with the source MinPlatformPkg module.

Cc: Chasel Chiu <chasel.chiu@...>
Cc: Nate DeSimone <nathaniel.l.desimone@...>
Cc: Liming Gao <gaoliming@...>
Cc: Eric Dong <eric.dong@...>
Signed-off-by: Michael Kubacki <michael.kubacki@...>

Michael Kubacki (3):
   MinPlatformPkg: Add FADT duty offset and duty width PCDs
   MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs
   SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs

Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |  3 +++
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |  4 ++--
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.c |  3 +++
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fadt.c |  4 ++--
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |  2 ++
Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++
Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPlatform.inf |  2 ++
  7 files changed, 29 insertions(+), 4 deletions(-)

Join { to automatically receive all group messages.