Re: [PATCH V3 1/7] MdePkg: Add CC_GUEST_TYPE in ConfidentialComputingGuestAttr.h


Gerd Hoffmann
 

Hi,

As the first step CC_GUEST_TYPE is defined in this patch. In the
next patch GUEST_TYPE will be deleted. This is to make sure the
bisect work correctly.
Hmm, what exactly went wrong? Splitting into two patches looks
pointless. If the change is too big for an all-in-one patch typical
bisectable splitting would be:

(1) add CC_GUEST_TYPE
(2) multiple patches switching code from GUEST_TYPE to CC_GUEST_TYPE
(for example one patch per Pkg).
(3) remove GUEST_TYPE

+//
+// Confidential computing guest type
+//
+typedef enum {
+ CCGuestTypeNonEncrypted = 0,
+ CCGuestTypeAmdSev,
+ CCGuestTypeIntelTdx,
+} CC_GUEST_TYPE;
Acked-by: Gerd Hoffmann <kraxel@...>

take care,
Gerd

Join devel@edk2.groups.io to automatically receive all group messages.