Re: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields


Zeng, Star
 

Personally, I think "eMMC" should be enough to instead " embedded Multi-Media Controller ".
Others look good to me.

And you'd better to get RB from ShellPkg's maintainer (Cced).

Thanks,
Star

-----Original Message-----
From: Ke, Bo-ChangX <bo-changx.ke@...>
Sent: Saturday, April 9, 2022 12:26 AM
To: devel@edk2.groups.io
Cc: Bi, Dandan <dandan.bi@...>; Zeng, Star <star.zeng@...>
Subject: [PATCH] ShellPkg: Update smbiosview type 41 with SMBIOS 3.5 fields

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3900

update smbiosview type 41 related fileds.

Signed-off-by: Bo Chang Ke <bo-changx.ke@...>
Cc: Dandan Bi <dandan.bi@...>
Cc: Star Zeng <star.zeng@...>
---
.../SmbiosView/QueryTable.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index c4a6acb167..7ec6d2b5f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -1766,6 +1766,30 @@ TABLE_ITEM OnboardDeviceTypesTable[] = {
0x0A,
L" Sas Controller"
},
+ {
+ 0x0B,
+ L" Wireless LAN"
+ },
+ {
+ 0x0C,
+ L" Bluetooth"
+ },
+ {
+ 0x0D,
+ L" WWAN"
+ },
+ {
+ 0x0E,
+ L" embedded Multi-Media Controller"
+ },
+ {
+ 0x0F,
+ L" NVMe Controller"
+ },
+ {
+ 0x10,
+ L" UFS Controller"
+ }
};

TABLE_ITEM SELTypesTable[] = {
--
2.32.0.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.