Agree with Jian.
I don’t understand this patch set and the feature. I request a design review in EDKII.
Thank you Yao Jiewen
toggle quoted messageShow quoted text
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wang, Jian J Sent: Tuesday, March 29, 2022 2:12 PM To: devel@edk2.groups.io; Gao, Liming <gaoliming@...>; Vang, Judah <judah.vang@...> Cc: Mistry, Nishant C <nishant.c.mistry@...> Subject: Re: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
Hi Judah,
You could update the readme in edk2-staging or your own forked branch.
Here's an example in edk2-staging repo:
https://github.com/tianocore/edk2-staging/tree/ProtectedVariable/libs
BTW, I didn't find the cover letter patch (the file with name starting with 0000). Please don't skip it and use it to give summary description for the whole patch series.
Regards, Jian
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming Sent: Monday, March 28, 2022 4:55 PM To: Vang, Judah <judah.vang@...>; devel@edk2.groups.io Cc: Wang, Jian J <jian.j.wang@...>; Mistry, Nishant C <nishant.c.mistry@...> Subject: [edk2-devel] 回复: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
Judah: Is there the detail information or wiki about the code design and usage for this feature?
Thanks Liming
-----邮件原件----- 发件人: Judah Vang <judah.vang@...> 发送时间: 2022年3月26日 6:03 收件人: devel@edk2.groups.io 抄送: Jian J Wang <jian.j.wang@...>; Liming Gao <gaoliming@...>; Nishant C Mistry <nishant.c.mistry@...>
主题: [PATCH v1 01/28] MdeModulePkg: Add a new GUID
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add a new Variable Store Guid.
Cc: Jian J Wang <jian.j.wang@...> Cc: Liming Gao <gaoliming@...> Cc: Nishant C Mistry <nishant.c.mistry@...> Signed-off-by: Judah Vang <judah.vang@...> --- MdeModulePkg/MdeModulePkg.dec | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 40601c95832b..681607db0da6 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -4,7 +4,7 @@ # and libraries instances, which are used for those modules. # # Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved. -# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR> +# Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved.<BR> # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR> # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR> # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR> @@ -93,6 +93,14 @@ [LibraryClasses] # TpmMeasurementLib|Include/Library/TpmMeasurementLib.h
+ ## @libraryclass Provides interfaces to encrypt/decrypt variable. + # + EncryptionVariableLib|Include/Library/EncryptionVariableLib.h + + ## @libraryclass Provides interfaces to encrypt/decrypt variable. + # + ProtectedVariableLib|Include/Library/ProtectedVariableLib.h + ## @libraryclass Provides authenticated variable services. # AuthVariableLib|Include/Library/AuthVariableLib.h @@ -505,6 +513,9 @@ [Ppis] gEdkiiPeiCapsuleOnDiskPpiGuid = { 0x71a9ea61, 0x5a35, 0x4a5d, { 0xac, 0xef, 0x9c, 0xf8, 0x6d, 0x6d, 0x67, 0xe0 } } gEdkiiPeiBootInCapsuleOnDiskModePpiGuid = { 0xb08a11e4, 0xe2b7, 0x4b75, { 0xb5, 0x15, 0xaf, 0x61, 0x6, 0x68, 0xbf, 0xd1 } }
+ ## Include/Ppi/ReadOnlyVariable2.h + gEfiPeiVariableStoreDiscoveredPpiGuid = { 0xa2fc038d, 0xfdf5, 0x4501, { 0xaf, 0x8e, 0x69, 0xb0, 0x20, 0xec, 0xe6, 0x63 } } + [Protocols] ## Load File protocol provides capability to load and unload EFI image into
memory and execute it. # Include/Protocol/LoadPe32Image.h -- 2.26.2.windows.1
|