回复: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py


gaoliming
 

Reviewed-by: Liming Gao <gaoliming@...>

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jake Garver
via groups.io
发送时间: 2022年1月21日 7:58
收件人: devel@edk2.groups.io; jbrasen@...;
ashishsingha@...
抄送: Jake Garver <jake@...>
主题: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py

Fix a Edk2Logger.warn() message format to match the arguments.

We ran into this after a failure in PcdValueInit. The failure was
masked by a new exception, "TypeError: not all arguments converted
during string formatting".

Signed-off-by: Jake Garver <jake@...>
---
BaseTools/Source/Python/Workspace/DscBuildData.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py
b/BaseTools/Source/Python/Workspace/DscBuildData.py
index 35ec5b37ff..d29b9bf13d 100644
--- a/BaseTools/Source/Python/Workspace/DscBuildData.py
+++ b/BaseTools/Source/Python/Workspace/DscBuildData.py
@@ -3033,7 +3033,7 @@ class DscBuildData(PlatformBuildClassObject):
returncode, StdOut, StdErr = DscBuildData.ExecuteCommand
(Command)
EdkLogger.verbose ('%s\n%s\n%s' % (Command, StdOut,
StdErr))
if returncode != 0:
- EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not
collect output from command: %s\n%s\n' % (Command, StdOut, StdErr))
+ EdkLogger.warn('Build', COMMAND_FAILURE, 'Can not
collect output from command: %s\n%s\n%s\n' % (Command, StdOut, StdErr))

#start update structure pcd final value
File = open (OutputValueFile, 'r')
--
2.17.1




Join devel@edk2.groups.io to automatically receive all group messages.