Re: [PATCH v2 0/6] MM communicate functionality in variable policy


Sami Mujawar
 

Hi Kun,

Thank you for this patch series.

These changes look good to me. For this series

Reviewed-by: Sami Mujawar <sami.mujawar@...>

Regards,

Sami Mujawar

On 21/12/2021 01:33 AM, Kun Qin via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3751

This patch series is a follow up of previous submission:
https://edk2.groups.io/g/devel/message/84140

v2 patches mainly focus on feedback for commits submitted in v1 patches:
a. Splitted the original ArmPkg patch into 4 separate patches;
b. Updated patches according to Uncrustify scanning results;

Patch v2 branch: https://github.com/kuqin12/edk2/tree/mm_communicate_check_v2

Cc: Jian J Wang <jian.j.wang@...>
Cc: Liming Gao <gaoliming@...>
Cc: Hao A Wu <hao.a.wu@...>
Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Zhiguang Liu <zhiguang.liu@...>
Cc: Leif Lindholm <leif@...>
Cc: Ard Biesheuvel <ardb+tianocore@...>
Cc: Bret Barkelew <Bret.Barkelew@...>
Cc: Michael Kubacki <michael.kubacki@...>

Kun Qin (6):
MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message
Length
MdePkg: MmCommunication2: Update MM communicate2 function description
ArmPkg: MmCommunicationDxe: MM communicate function argument
attributes
ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**`
checks
ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check
ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength`
check

ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 46 ++++++++++++--------
MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c | 10 ++---
MdePkg/Include/Protocol/MmCommunication2.h | 13 +++---
3 files changed, 41 insertions(+), 28 deletions(-)

Join devel@edk2.groups.io to automatically receive all group messages.