回复: [edk2-devel] [PATCH v2 2/6] MdePkg: MmCommunication2: Update MM communicate2 function description


gaoliming
 

Reviewed-by: Liming Gao <gaoliming@...>

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
发送时间: 2021年12月21日 9:34
收件人: devel@edk2.groups.io
抄送: Michael D Kinney <michael.d.kinney@...>; Liming Gao
<gaoliming@...>; Zhiguang Liu <zhiguang.liu@...>
主题: [edk2-devel] [PATCH v2 2/6] MdePkg: MmCommunication2: Update
MM communicate2 function description

Current MM communicate2 function definition described input arguments
`CommBufferPhysical`, `CommBufferVirtual` and `CommSize` as input only,
which mismatches with the "input and output type" as in PI specification.

This change updated function descriptions of MM communite2 definition to
match input argument types.

Cc: Michael D Kinney <michael.d.kinney@...>
Cc: Liming Gao <gaoliming@...>
Cc: Zhiguang Liu <zhiguang.liu@...>

Signed-off-by: Kun Qin <kuqin12@...>
---

Notes:
v2:
- Newly added

MdePkg/Include/Protocol/MmCommunication2.h | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/MdePkg/Include/Protocol/MmCommunication2.h
b/MdePkg/Include/Protocol/MmCommunication2.h
index 3495a7327f76..1b56320c7fff 100644
--- a/MdePkg/Include/Protocol/MmCommunication2.h
+++ b/MdePkg/Include/Protocol/MmCommunication2.h
@@ -27,12 +27,13 @@ typedef struct
_EFI_MM_COMMUNICATION2_PROTOCOL
EFI_MM_COMMUNICATION2_PROTOCOL;

This function provides a service to send and receive messages from a
registered UEFI service.

- @param[in] This The
EFI_MM_COMMUNICATION_PROTOCOL instance.
- @param[in] CommBufferPhysical Physical address of the MM
communication buffer
- @param[in] CommBufferVirtual Virtual address of the MM
communication buffer
- @param[in] CommSize The size of the data buffer being
passed in. On exit, the size of data
- being returned. Zero if the handler
does not wish to reply with any data.
- This parameter is optional and may
be NULL.
+ @param[in] This The
EFI_MM_COMMUNICATION_PROTOCOL instance.
+ @param[in, out] CommBufferPhysical Physical address of the MM
communication buffer
+ @param[in, out] CommBufferVirtual Virtual address of the MM
communication buffer
+ @param[in, out] CommSize The size of the data buffer
being passed in. On exit, the
+ size of data being returned.
Zero if the handler does not
+ wish to reply with any data.
This parameter is optional
+ and may be NULL.

@retval EFI_SUCCESS The message was successfully
posted.
@retval EFI_INVALID_PARAMETER CommBufferPhysical was NULL or
CommBufferVirtual was NULL.
--
2.32.0.windows.1




Join {devel@edk2.groups.io to automatically receive all group messages.