Re: [EXTERNAL] [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools


Leif Lindholm
 

On Tue, Nov 02, 2021 at 16:34:15 -0700, Andrew Fish via groups.io wrote:
No objections to this for any of my use-cases, but I'd like for one of
the BaseTools maintainers to comment on whether this breaks anything
with regards to EDK_TOOLS_PATH, or if we can finally get rid of that
and replace it with $WORKSPACE/BaseTools globally.

Our internal repo uses EDK_TOOLS_PATH. In our case it is
$(WORKSPACE)/edk2/BaseTools. We have a PACKAGES_PATH set to
$(WORKSPACE)/edk2 and magic happens.

So I’m thinking maybe:
$(EDK_TOOLS_PATH)/Bin/GccLto
Vs:
$(WORKSPACE)/BaseTools/Bin/GccLto

If EDK_TOOLS_PATH gets ripped out, it should be one atomic remove,
but let us not stick that on Bret.
Agreed. I'd be happy with your proposed solution.

/
Leif

Join devel@edk2.groups.io to automatically receive all group messages.