Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg


Bret Barkelew
 

I’d be amenable to that. @Sean?

 

- Bret

 

From: Leif Lindholm via groups.io
Sent: Tuesday, November 2, 2021 2:51 AM
To: brbarkel@...
Cc: devel@edk2.groups.io; Ard Biesheuvel; Kinney, Michael D; Liming Gao; Zhiguang Liu; Sami Mujawar; Yao, Jiewen; Supreeth Venkatesh; Maciej Rabeda; Jiaxin Wu; Siyuan Fu; Ni, Ray; Zhichao Gao; Sean Brogan
Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

 

On Mon, Nov 01, 2021 at 12:56:37 -0700, brbarkel@... wrote:
> From: Bret Barkelew <brbarkel@...>
>
> This aligns better with Mu's philosophy around dependency structuring
> and is one of the steps to enable Basecore to have zero CI dependencies
> on other Mu repos.
>
> REF: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3649&amp;data=04%7C01%7CBret.Barkelew%40microsoft.com%7C6acadbd5a03f44edf9c408d99de642ee%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637714434603817528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=AmwBKl6uWTs1VYo3Hw3I3RglkhPrWXhKPkobrwQid84%3D&amp;reserved=0
>

Only one comment on this patch really.

>  ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf => MdePkg/Library/CompilerIntrinsicsLib/ArmCompilerIntrinsicsLib.inf | 3 +--

Could we just keep the .inf name as is?

I think we're getting closer to the x86 folk accepting that they
need this too, rather than keep inventing new dialects of C in the
desperate hope that the compiler won't generate stdlib calls it's
fully permitted to generate whenever it feels like.

/
    Leif




 

Join devel@edk2.groups.io to automatically receive all group messages.