[PATCH] DynamicTablesPkg: Fix unitialized variable use


Moritz Fischer
 

In the success case we should return EFI_SUCCESS rather than returning
a potentially unitialized value of Status.

Cc: Sami Mujawar <Sami.Mujawar@...>
Cc: Alexei Fedorov <Alexei.Fedorov@...>
Signed-off-by: Moritz Fischer <moritzf@...>
---
.../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
index 0bdb6c24c5bb..e9e1a85ede63 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
@@ -91,7 +91,7 @@ LinkRdNode (
*NewRdNode = RdNode;
}

- return Status;
+ return EFI_SUCCESS;

error_handler:
Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);
--
2.33.0.1079.g6e70778dc9-goog

Join {devel@edk2.groups.io to automatically receive all group messages.