Re: [PATCH 0/2] work area fixes


Yao, Jiewen
 

Yes, I tried again today. It works.

https://github.com/tianocore/edk2/pull/2080

Pushed:
36b561623a4b8a6c7fea0b1b01f6789f2adf97e0.. 11a4af85a438b5b3d8cde942a209908219c57363

Thank you
Yao Jiewen

-----Original Message-----
From: Xu, Min M <min.m.xu@intel.com>
Sent: Tuesday, October 19, 2021 8:22 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io;
brijesh.singh@amd.com; Liming Gao <gaoliming@byosoft.com.cn>; Kinney,
Michael D <michael.d.kinney@intel.com>; sean.brogan@microsoft.com
Cc: James Bottomley <jejb@linux.ibm.com>; Tom Lendacky
<thomas.lendacky@amd.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
Ard Biesheuvel <ardb+tianocore@kernel.org>; Erdem Aktas
<erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>; Gerd
Hoffmann <kraxel@redhat.com>
Subject: RE: [edk2-devel] [PATCH 0/2] work area fixes

Jiewen
I just create a new PR based on the latest commit (2108698346) for the patch-
set of "work area fixes" and it seems all checks have passed.
https://github.com/tianocore/edk2/pull/2078

I suspect the previous failure was caused by the un-stability of EDK2 CI system.
Maybe you can create a new PR and try it again.

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com>
Sent: Monday, October 18, 2021 10:49 PM
To: devel@edk2.groups.io; brijesh.singh@amd.com; Liming Gao
<gaoliming@byosoft.com.cn>; Kinney, Michael D
<michael.d.kinney@intel.com>; sean.brogan@microsoft.com
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
<min.m.xu@intel.com>;
Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
<jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
Erdem Aktas <erdemaktas@google.com>; Michael Roth
<Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: RE: [edk2-devel] [PATCH 0/2] work area fixes

That is weird. But I am not tool person.

HI Liming/Mike/Sean
Would you please take a look and help us understand what's happening?

Thank you
Yao Jiewen

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Brijesh
Singh via groups.io
Sent: Monday, October 18, 2021 10:45 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
Cc: brijesh.singh@amd.com; James Bottomley <jejb@linux.ibm.com>; Xu,
Min M <min.m.xu@intel.com>; Tom Lendacky
<thomas.lendacky@amd.com>;
Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
<ardb+tianocore@kernel.org>; Erdem Aktas <erdemaktas@google.com>;
Michael Roth <Michael.Roth@amd.com>; Gerd Hoffmann
<kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH 0/2] work area fixes


On 10/18/21 8:14 AM, Yao, Jiewen wrote:
Hi
This patch failed in PR -
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
ub.c
om%2Ftianocore%2Fedk2%2Fpull%2F2076&amp;data=04%7C01%7Cbrijesh.sing
h%40amd.com%7C20804cf7726f4528ee2608d9923950ba%7C3dd8961fe4884e6
08e11a82d994e183d%7C0%7C0%7C637701597143373879%7CUnknown%7CTW
FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI
6Mn0%3D%7C1000&amp;sdata=S4RXWkQ5Hs4yr8FvEvKJSYGVPZS7mrBfvjRUKZF
dsZ8%3D&amp;reserved=0

Please take a look.

You are encouraged to try PR before submit next time.
I did ran PR before the submission and it all passed. The error this
link is reports have something to do with the python script used for
running the PR itself. I am not sure what I can do to fix it. Sounds
like a bug in the tool ?




Thank you
Yao Jiewen

-----Original Message-----
From: Yao, Jiewen
Sent: Monday, October 18, 2021 12:53 PM
To: devel@edk2.groups.io; brijesh.singh@amd.com
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
<min.m.xu@intel.com>;
Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
<jordan.l.justen@intel.com>; Ard Biesheuvel
<ardb+tianocore@kernel.org>; Erdem Aktas <erdemaktas@google.com>;
Michael Roth <Michael.Roth@amd.com>; Gerd Hoffmann
<kraxel@redhat.com>
Subject: RE: [edk2-devel] [PATCH 0/2] work area fixes

Series: Acked-by: Jiewen Yao <Jiewen.yao@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
Brijesh Singh via groups.io
Sent: Friday, October 15, 2021 2:17 AM
To: devel@edk2.groups.io
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M
<min.m.xu@intel.com>;
Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky
<thomas.lendacky@amd.com>; Justen, Jordan L
<jordan.l.justen@intel.com>;
Ard Biesheuvel <ardb+tianocore@kernel.org>; Erdem Aktas
<erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>;
Gerd
Hoffmann <kraxel@redhat.com>; Brijesh Singh
<brijesh.singh@amd.com>
Subject: [edk2-devel] [PATCH 0/2] work area fixes

We missed updating the AmdSev package and Ia32 buid to use new
work
area.

Brijesh Singh (2):
Ovmfpkg: update Ia32 build to use new work area
OvmfPkg/AmdSev: update the fdf to use new workarea PCD

OvmfPkg/AmdSev/AmdSevX64.fdf | 9 ++++++++-
OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++
OvmfPkg/ResetVector/ResetVector.nasmb | 3 ++-
3 files changed, 13 insertions(+), 2 deletions(-)

--
2.25.1






Join devel@edk2.groups.io to automatically receive all group messages.