Re: [PATCH V9 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm


Min Xu
 

On October 12, 2021 9:23 PM, Lendacky Thomas wrote:
On 10/11/21 9:37 PM, Min Xu wrote:
diff --git a/OvmfPkg/ResetVector/Main.asm
b/OvmfPkg/ResetVector/Main.asm index ae90a148fce7..a501fbe880f2
100644
--- a/OvmfPkg/ResetVector/Main.asm
+++ b/OvmfPkg/ResetVector/Main.asm
@@ -36,6 +36,14 @@ Main16:

BITS 32

+%ifdef ARCH_X64
A regular SEV guest can be built in the hybrid IA32 and X64 configuration, so this
will break existing SEV firmwares built in that manner. Only SEV-ES and SEV-SNP
require the full X64 confguration.
WORK_AREA_GUEST_TYPE is defined in https://github.com/tianocore/edk2/blob/master/OvmfPkg/ResetVector/ResetVector.nasmb#L75 and previously it was cleared in https://github.com/tianocore/edk2/blob/master/OvmfPkg/ResetVector/Ia32/PageTables64.asm#L47. These 2 lines are both surrounded by ARCH_X64.
So in this commit, the clearance of WORK_AREA_GUEST_TYPE in Main.asm is surrounded by ARCH_X64 too.
Brijesh, what's your comments on this change?

Thanks!
Min

Join devel@edk2.groups.io to automatically receive all group messages.