Re: [PATCH v1 1/1] MdeModulePkg/SdDxe: Remove redundant SdDxeExtra.uni file


Wu, Hao A
 

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
Konstantin Aladyshev
Sent: Sunday, October 10, 2021 6:54 PM
To: devel@edk2.groups.io
Cc: Wang, Jian J <jian.j.wang@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>
Subject: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/SdDxe: Remove
redundant SdDxeExtra.uni file

'SdDxeExtra.uni' duplicates 'SdDxe.uni' and is not even referenced in the
module INF file.

Thanks for the patch.

Could you help to:
1. Update the SdDxeExtra.uni file to mimic what MdeModulePkg\Bus\Sd\EmmcDxe\EmmcDxeExtra.uni is currently doing
2. Add an "[UserExtensions.TianoCore."ExtraFiles"]" filed for both:
MdeModulePkg\Bus\Sd\EmmcDxe\EmmcDxe.inf
MdeModulePkg\Bus\Sd\SdDxe\SdDxe.inf

Best Regards,
Hao Wu



Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
---
MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
b/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
deleted file mode 100644
index eb8ebd5a3594..000000000000
--- a/MdeModulePkg/Bus/Sd/SdDxe/SdDxeExtra.uni
+++ /dev/null
@@ -1,15 +0,0 @@
-// /** @file-// SD memory card device driver to manage the SD memory
card device and provide interface for upper layer-// access.-//-// Copyright (c)
2015, Intel Corporation. All rights reserved.<BR>-//-// SPDX-License-
Identifier: BSD-2-Clause-Patent-//-// **/---#string STR_MODULE_ABSTRACT
#language en-US "SD device driver to manage the SD memory card device
and provide interface for upper layer access"--#string
STR_MODULE_DESCRIPTION #language en-US "This driver follows the
UEFI driver model and layers on the SdMmcPassThru protocol. It installs
BlockIo and BlockIo2 protocols on the SD device."---
2.25.1



-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#81725): https://edk2.groups.io/g/devel/message/81725
Mute This Topic: https://groups.io/mt/86211248/1768737
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [hao.a.wu@intel.com] -
=-=-=-=-=-=

Join devel@edk2.groups.io to automatically receive all group messages.