Re: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection dynamic and set it accordingly


Chiu, Chasel
 

-----Original Message-----
From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>
Sent: Thursday, September 16, 2021 11:45 AM
To: devel@edk2.groups.io
Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel
<chasel.chiu@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desimone@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: [PATCH v1] IntelFsp2WrapperPkg: Make PcdFspModeSelection
dynamic and set it accordingly

From: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3632

PcdFspModeSelection will be used to set FSP mode.
Make PcdFspModeSelection dynamic and set it accordingly.

Signed-off-by: Zhang Xiaoqiang <xiaoqiang.zhang@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
---
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
index a3b9363779..b8dac1b574 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
@@ -82,12 +82,6 @@
# @Prompt Skip FSP API from FSP wrapper.


gIntelFsp2WrapperTokenSpaceGuid.PcdSkipFspApi|0x00000000|UINT32|0x4
0000009



- ## This PCD decides how Wrapper code utilizes FSP

- # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
calling FSP API)

- # 1: API mode (FSP Wrapper will call FSP API)

- #

-
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
T8|0x4000000A

-

## This PCD decides how FSP is measured

# 1) The BootGuard ACM may already measured the FSP component, such
as FSPT/FSPM.

# We need a flag (PCD) to indicate if there is need to do such FSP
measurement or NOT.

@@ -106,6 +100,12 @@

gIntelFsp2WrapperTokenSpaceGuid.PcdFspMeasurementConfig|0x0000000
0|UINT32|0x4000000B



[PcdsFixedAtBuild, PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx]

+ ## This PCD decides how Wrapper code utilizes FSP

+ # 0: DISPATCH mode (FSP Wrapper will load PeiCore from FSP without
calling FSP API)

+ # 1: API mode (FSP Wrapper will call FSP API)

+ #

+
gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection|0x00000001|UIN
T8|0x4000000A

+

#

## These are the base address of FSP-M/S

#

--
2.32.0.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.