Thanks, that makes sense. I haven't reviewed the entire patch, so I've given an Acked-by instead.
toggle quoted messageShow quoted text
On 9/2/21 2:46 PM, Kinney, Michael D wrote:
Some of the items you are observing are due to following the exact
same pattern as the Python 2.x ports. There are many things that can
get cleaned up in the Python 3.x ports. I would prefer to see this
initial functional version go in and add new BZs for additional cleanups.
-----Original Message-----It looks like there are elements that do not follow MarkDown and the formatting
From: email@example.com <firstname.lastname@example.org> On Behalf Of Rebecca Cran
Sent: Thursday, September 2, 2021 11:41 AM
To: email@example.com; Kinney, Michael D <firstname.lastname@example.org>
Cc: Jayaprakash, N <email@example.com>
Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python/Python-3.6.8: Py 3.6.8 UEFI changes
On 9/2/21 11:12 AM, Michael D Kinney wrote:
AppPkg/AppPkg.dsc | 3 +This looks like it's formatted using Markdown, so should it be
.../Python/Python-3.6.8/Py368ReadMe.txt | 220 +
looks bad when using a MarkDown viewer. I would recommend leaving it as .txt for
now. We can enter a new issue to convert to MD.
There are several limitations to the BAT file. It is just being reused from the
create mode 100644 AppPkg/Applications/Python/Python-3.6.8/create_python368_pkg.batThe xcopy commands should probably have error checking after them.
Python 2.x ports. I think it would be better to port this to a Python script and
add all error checking in that version. We can enter a new issues for this Python