Re: [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build


Nate DeSimone
 

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, August 5, 2021 11:28 AM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: [edk2-devel] [edk2-platforms] [PATCH] IpmiFeaturePkg: Fix standalone package build

Building the IpmiFeaturePkg standalone
(not as part of a platform build) currently fails because the IpmiPlatformHookLib was added but the reference to the NULL implementation of that LibraryClass was miseed.

Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
.../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index 05a7d4f0af..a6eccb428b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeat
+++ ure.dsc
@@ -48,6 +48,7 @@
# IPMI Feature Package
#####################################
IpmiCommandLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
+
+ IpmiPlatformHookLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPla
+ tformHookLibNull/IpmiPlatformHookLibNull.inf

[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
#######################################
--
2.27.0.windows.1

Join devel@edk2.groups.io to automatically receive all group messages.