On Mon, 2021-07-26 at 00:55 +0000, Yao, Jiewen wrote:
Hi JamesThe history predates me. It was already done for the Bhyve package
which also has a modified PlatformBootManagerLib when I came along with
this. However, only having Library in the top level package seems to
be a common edk2 pattern if you run a find.
It looks not reasonable to me. AmdSev is just a feature. A featureWe do? Running
find . -name Library -print
only turns up
As not following the top level package only pattern.
Also, the instance name "Grub" is very confusing. I comparedIt's called Grub because it places Grub in the Fv for combined pre-
attestation. Either SEV or TDX could use this (Although TDX looks
likely not to want to).
For example, XEN feature removing and PIIX4 difference has nothing toIt's part of the boot path stripping to make sure there's a hard
failure if Grub fails to execute. There's a Bugzilla requiring more of
this because a grub only booting platform library needs fewer
extraneous things which could constitute an attack surface for the
It is a big misleading. Can we move the PlatformBootManagerLibGrub ToI think you probably want to ask around older edk2 package maintainers
and see if there's any reason for this pattern, which seems to be
strongly enforced. If no-one can remember, then likely it can be