Re: [PATCH v4 0/4] SEV Live Migration support for OVMF.


Ashish Kalra
 

Hello Laszlo,

On Wed, Jun 23, 2021 at 06:49:06PM +0200, Laszlo Ersek wrote:
On 06/23/21 18:42, Laszlo Ersek wrote:
On 06/22/21 19:46, Ashish Kalra wrote:
Please find below your reply on v3 of this patch-set :

Please include such a patch in v4 -- if Tom and Brijesh agree, I'd like to put the new lib explicitly under their reviewership.

Also, I plan to review this series (v4, at this point) only for formalities. I'd like to receive an R-b from Tom or Brijesh [*], and another from Dov or a colleague at IBM, for this series; those together should suffice for merging the library.

So, if you are fine with this approach, then probably Tom or Brijesh can
take these patches under their reviewership and provide their R-b for
this patch-set to be accepted and merged.
Indeed. This helps. Thanks.

I'll keep this patch set in my review queue then, for said "formalities
review".
Please do file a TianoCore Feature Request BZ for this, and reference
the bug URL in the commit messages. One important purpose of such a BZ
is to succinctly link together all versions of a patch set -- that way
poor maintainers know where to find previous versions, even if the blurb
subject line changes over time. I also like to capture "permanent
workflow notes" like the above in BZs (basically a high-level summary of
who does what).
I have filed a new TianoCore Feature request BZ for this.
https://bugzilla.tianocore.org/show_bug.cgi?id=3467

I will refer this bug in future commit messages for this patch-set.

Please let me know if you want me to add additional contents and
comments to this bug.

Thanks,
Ashish

For now it seems that a v5 will be necessary. Please keep me on CC, and
when you have the BZ filed, we should link all past and future versions
into it.

Thanks
Laszlo

Join devel@edk2.groups.io to automatically receive all group messages.