Re: [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h


Ard Biesheuvel
 

On Fri, 11 Jun 2021 at 00:44, Rebecca Cran <rebecca@nuviainc.com> wrote:

On 6/10/21 9:04 AM, Ard Biesheuvel wrote:
On Tue, 8 Jun 2021 at 15:54, Rebecca Cran <rebecca@nuviainc.com> wrote:
Many of the cache definitions in ArmLibPrivate.h are being used outside
of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them
public, and remove the include of ArmLibPrivate.h from files in
Universal/Smbios.

Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
Hi Rebecca,

If these definitions describe anything more than the software
interface exposed by the library, they really belong under
IndustryStandard/ not Library.

It looks like I'd need to create a new file under
ArmPkg/Include/IndustryStandard since the existing files don't look
appropriate. I was wondering if a filename like ArmCache.h would be good?
Fine with me.

Join devel@edk2.groups.io to automatically receive all group messages.