Re: [PATCH v1 0/8] Measured SEV boot with kernel/initrd/cmdline


Laszlo Ersek
 

On 06/09/21 14:25, Dov Murik wrote:


On 08/06/2021 18:59, Laszlo Ersek wrote:
On 06/08/21 14:09, Dov Murik wrote:
On 08/06/2021 13:59, Laszlo Ersek wrote:
On 06/08/21 11:57, Dov Murik wrote:

But if we go with (1) -- do you (and Ard) prefer:

(a) leave X86QemuLoadImageLib as it is in master;

-or-

(b) modify X86QemuLoadImageLib the "main" path to use the
QemuKernelLoaderFs (what I started doing) and leave the "legacy" path
with QemuFwCfg

?
I prefer option (a), with the extension that we need to update the
following file-top comment in the files under
"OvmfPkg/Library/X86QemuLoadImageLib":

X86 specific implementation of QemuLoadImageLib library class interface
with support for loading mixed mode images and non-EFI stub images
First attempt at this is submitted to the mailing list:
https://edk2.groups.io/g/devel/message/76265


We should add a warning there that this library instance (a) depends on
fw_cfg directly, and (b) is therefore unsuitable for blob verification
purposes.
I'll add the warning (b) when I add the blob verification feature.
That makes sense to me, thanks.
Laszlo

Join devel@edk2.groups.io to automatically receive all group messages.