Re: [Patch V3 4/9] MdeModulePkg: Add new structure for the Universal Payload SMBios Table Info Hob


Wu, Hao A
 

-----Original Message-----
From: Liu, Zhiguang <zhiguang.liu@intel.com>
Sent: Friday, June 4, 2021 5:42 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
<gaoliming@byosoft.com.cn>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao
A <hao.a.wu@intel.com>
Subject: [Patch V3 4/9] MdeModulePkg: Add new structure for the Universal
Payload SMBios Table Info Hob

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>

Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdeModulePkg/Include/UniversalPayload/SmbiosTable.h | 28
++++++++++++++++++++++++++++
MdeModulePkg/MdeModulePkg.dec | 6 ++++++
2 files changed, 34 insertions(+)

diff --git a/MdeModulePkg/Include/UniversalPayload/SmbiosTable.h
b/MdeModulePkg/Include/UniversalPayload/SmbiosTable.h
new file mode 100644
index 0000000000..3aaa926396
--- /dev/null
+++ b/MdeModulePkg/Include/UniversalPayload/SmbiosTable.h
@@ -0,0 +1,28 @@
+/** @file

+ Define the structure for the Payload SmBios.

+

+Copyright (c) 2021, Intel Corporation. All rights reserved.<BR>

+SPDX-License-Identifier: BSD-2-Clause-Patent

+

Could you help to add the specification reference information in the header file description comment?

With this handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu



+**/

+

+#ifndef _PLD_SMBIOS_TABL_H_

+#define _PLD_SMBIOS_TABL_H_

+

+#include <Uefi.h>

+#include <UniversalPayload/UniversalPayload.h>

+

+#pragma pack (1)

+

+typedef struct {

+ PLD_GENERIC_HEADER PldHeader;

+ EFI_PHYSICAL_ADDRESS SmBiosEntryPoint;

+} PLD_SMBIOS_TABLE;

+

+#pragma pack()

+

+#define PLD_SMBIOS_TABLE_REVISION 1

+

+extern GUID gPldSmbios3TableGuid;

+extern GUID gPldSmbiosTableGuid;

+#endif //_PLD_SMBIOS_TABL_H_

diff --git a/MdeModulePkg/MdeModulePkg.dec
b/MdeModulePkg/MdeModulePkg.dec
index 671d0f33c8..45324d2e20 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -410,6 +410,12 @@
## Include/UniversalPayload/PciRootBridges.h

gPldPciRootBridgeInfoGuid = { 0xec4ebacb, 0x2638, 0x416e, { 0xbe, 0x80,
0xe5, 0xfa, 0x4b, 0x51, 0x19, 0x01 }}



+ ## Include/UniversalPayload/SmbiosTable.h

+ gPldSmbios3TableGuid = { 0x92b7896c, 0x3362, 0x46ce, { 0x99, 0xb3, 0x4f,
0x5e, 0x3c, 0x34, 0xeb, 0x42 } }

+

+ ## Include/UniversalPayload/SmbiosTable.h

+ gPldSmbiosTableGuid = { 0x590a0d26, 0x06e5, 0x4d20, { 0x8a, 0x82, 0x59,
0xea, 0x1b, 0x34, 0x98, 0x2d } }

+

[Ppis]

## Include/Ppi/AtaController.h

gPeiAtaControllerPpiGuid = { 0xa45e60d1, 0xc719, 0x44aa, { 0xb0, 0x7a,
0xaa, 0x77, 0x7f, 0x85, 0x90, 0x6d }}

--
2.30.0.windows.2

Join devel@edk2.groups.io to automatically receive all group messages.