Re: [PATCH 00/43] OvmfPkg: remove Xen support from OvmfPkg*.dsc, in favor of OvmfXen.dsc


Laszlo Ersek
 

On 05/31/21 17:06, Philippe Mathieu-Daudé wrote:
On 5/27/21 10:55 AM, Laszlo Ersek wrote:
On 05/27/21 09:34, Ard Biesheuvel wrote:
On Wed, 26 May 2021 at 22:15, Laszlo Ersek <lersek@...> wrote:

Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Repo: https://pagure.io/lersek/edk2.git
Branch: xen_split_bz_2122

This patch set removes dynamic Xen enlightenment from the following
platforms:

OvmfPkg/OvmfPkgIa32.dsc
OvmfPkg/OvmfPkgIa32X64.dsc
OvmfPkg/OvmfPkgX64.dsc

In Xen guests, the following platform should be used:

OvmfPkg/OvmfXen.dsc
For the series,

Reviewed-by: Ard Biesheuvel <ardb@...>
Thank you, Ard!

I hope the large patch count (with the small patch bodies and the
not-so-short commit messages) didn't get on your nerves! I really did
make an effort to find a good balance. E.g. in the "clean up and sort
#includes & INF files" patches.
I certainly prefer a long series of little patches (so I can stop /
resume the review) rather than a short one of big patches which
burn my review cycle quicker.

This one in particular made a complex refactor easy to review,
thanks!
Thank you, Phil!
Laszlo


Phil.

Join devel@edk2.groups.io to automatically receive all group messages.