Re: [PATCH 36/43] OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF #includes

Philippe Mathieu-Daudé <philmd@...>

On 5/26/21 10:14 PM, Laszlo Ersek wrote:
- Sort all sections in the INF file.

- Remove unused packages (MdeModulePkg) and lib classes (BaseMemoryLib)
from the INF file.

- Restrict some lib classes (BaseLib, HobLib) and GUIDs (gEfiXenInfoGuid)
to IA32 and X64, in the INF file; only the IA32/X64 Xen implementation
requires these.

- Don't make "SmbiosPlatformDxe.h" #include everything just as a
convenience. Spell out directly needed #includes in every file (annotate
each with an example identifier consumed), drop unused #includes.

- Keep #includes sorted.

- Remove the leading underscore from the #include guard macro name in

Cc: Anthony Perard <>
Cc: Ard Biesheuvel <>
Cc: Jordan Justen <>
Cc: Julien Grall <>
Cc: Philippe Mathieu-Daudé <>
Signed-off-by: Laszlo Ersek <>
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 20 ++++++++++----------
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 15 +++------------
OvmfPkg/SmbiosPlatformDxe/Qemu.c | 8 +++++---
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 6 ++++++
OvmfPkg/SmbiosPlatformDxe/X86Xen.c | 6 ++++--
5 files changed, 28 insertions(+), 27 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <>

Join to automatically receive all group messages.