Re: [PATCH 28/43] OvmfPkg/PciHostBridgeLib: consolidate #includes and INF file sections #includes


Philippe Mathieu-Daudé
 

On 5/26/21 10:14 PM, Laszlo Ersek wrote:
- In every C file, list every necessary public #include individually, with
an example identifier that's actually consumed.

- Place all public #includes first, all module-private #includes second.
Separate them with a single empty line. Keep each section sorted in
itself.

- Sort all sections in the INF file, except [Defines].

- Add unlisted lib classes.

- Remove unnecessary #include directives, add unlisted #include
directives.

Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 7 +++---
OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 22 +++++++-----------
OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 24 +++++++++-----------
3 files changed, 23 insertions(+), 30 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Join devel@edk2.groups.io to automatically receive all group messages.